Change token to agent_id

kacpersaw · kacpersaw · commit f6861691d772 · 2025-08-06T08:54:03.000Z
diff --git a/docs/resources/external_agent.md b/docs/resources/external_agent.md
@@ -17,7 +17,7 @@ Define an external agent to be used in a workspace.
 
 ### Required
 
-- `token` (String, Sensitive) Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.
+- `agent_id` (String) The `id` property of a `coder_agent` resource to associate with.
 
 ### Read-Only
 
diff --git a/provider/external_agent.go b/provider/external_agent.go
@@ -20,12 +20,11 @@ func externalAgentResource() *schema.Resource {
 		ReadContext:   schema.NoopContext,
 		DeleteContext: schema.NoopContext,
 		Schema: map[string]*schema.Schema{
-			"token": {
+			"agent_id": {
+				Type:        schema.TypeString,
+				Description: "The `id` property of a `coder_agent` resource to associate with.",
 				ForceNew:    true,
 				Required:    true,
-				Sensitive:   true,
-				Description: "Set the environment variable `CODER_AGENT_TOKEN` with this token to authenticate an agent.",
-				Type:        schema.TypeString,
 			},
 		},
 	}
diff --git a/provider/external_agent_test.go b/provider/external_agent_test.go
@@ -21,18 +21,26 @@ func TestExternalAgent(t *testing.T) {
 				Config: `
 				provider "coder" {
 				}
+
+				resource "coder_agent" "dev" {
+					os = "linux"
+					arch = "amd64"
+				}
 				
-				resource "coder_external_agent" "main" {
-					token       = "token"
+				resource "coder_external_agent" "dev" {
+					agent_id = coder_agent.dev.id
 				}
 				`,
 				Check: func(state *terraform.State) error {
 					require.Len(t, state.Modules, 1)
-					resource := state.Modules[0].Resources["coder_external_agent.main"]
-					require.NotNil(t, resource)
-					value := resource.Primary.Attributes["token"]
-					require.NotNil(t, value)
-					require.Greater(t, len(value), 0)
+					require.Len(t, state.Modules[0].Resources, 2)
+
+					agentResource := state.Modules[0].Resources["coder_agent.dev"]
+					require.NotNil(t, agentResource)
+					externalAgentResource := state.Modules[0].Resources["coder_external_agent.dev"]
+					require.NotNil(t, externalAgentResource)
+
+					require.Equal(t, agentResource.Primary.Attributes["id"], externalAgentResource.Primary.Attributes["agent_id"])
 					return nil
 				},
 			}},
