ci: check for unstaged files correctly during gen (#142)

ethanndickson · web-flow · commit 1c5fef003684 · 2024-11-15T22:00:14.000+11:00
Discovered in #141 that CI could pass even when `make gen` could produce a new file.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -54,8 +54,10 @@ jobs:
 
       - name: git diff
         run: |
-          git diff --compact-summary --exit-code || \
-            (echo; echo "Unexpected difference in directories after code generation. Run 'go generate ./...' command and commit."; exit 1)
+          if [[ -n $(git ls-files --other --modified --exclude-standard) ]]; then
+            echo "Unexpected difference in directories after code generation. Run 'make gen' and include the output in the commit."
+            exit 1
+          fi
 
   # Run acceptance tests in a matrix with Terraform CLI versions
   test:
