fix: skip validating unknown versions list (#115)

ethanndickson · web-flow · commit 269046ef5ff7 · 2024-10-21T17:13:23.000+11:00
This fixes an error when setting the `versions` attribute of a
`coderd_template` using a variable, e.g:

```terraform
resource "coderd_template" "dev" {
    versions = var.template_versions
    [...]
}

variable "template_versions" {
  description = "Versions of the Coder template."
  default = [
    {
      directory   = "modules/"
      active      = true
      tf_vars     = [
          {
              name  = "coder_instance"
              value = "prod"
          }
      ]
    }
  ]
}
```

would return:
```
│ Error: Value Conversion Error
│
│   with module.devcontainers.coderd_template.dev,
│ An unexpected error was encountered trying to build a value. This is always an error in the provider. Please report the following to the provider
│ developer:
│
│ Received unknown value, however the target type cannot handle unknown values. Use the corresponding `types` package type or a custom type that handles
│ unknown values.
│
│ Path:
│ Target Type: []provider.TemplateVersion
│ Suggested Type: basetypes.ListValue
```

This error was caused by attempting to validate the versions list
without checking if the config value is unknown. Normally, this value
should never be unknown, as it's required, but it looks like Terraform
does a configuration validation *before* variables are populated, as
well as after.

To confirm this is the correct solution, we see that all the default
validators perform the same null &amp; unknown checks, e.g:
```go
func (v lengthBetweenValidator) ValidateString(ctx context.Context, request validator.StringRequest, response *validator.StringResponse) {
	if request.ConfigValue.IsNull() || request.ConfigValue.IsUnknown() {
		return
	}
	...
}
```
diff --git a/internal/provider/template_resource.go b/internal/provider/template_resource.go
@@ -888,6 +888,10 @@ func (a *activeVersionValidator) MarkdownDescription(context.Context) string {
 
 // ValidateList implements validator.List.
 func (a *activeVersionValidator) ValidateList(ctx context.Context, req validator.ListRequest, resp *validator.ListResponse) {
+	if req.ConfigValue.IsNull() || req.ConfigValue.IsUnknown() {
+		return
+	}
+
 	var data []TemplateVersion
 	resp.Diagnostics.Append(req.ConfigValue.ElementsAs(ctx, &data, false)...)
 	if resp.Diagnostics.HasError() {
