fix: set display name during create (#24)

ethanndickson · web-flow · commit ee5c4e5b4dba · 2024-07-15T17:25:39.000+10:00
diff --git a/integration/user-test/main.tf b/integration/user-test/main.tf
@@ -25,7 +25,6 @@ resource "coderd_user" "ethan2" {
   username = "${data.coderd_user.ethan.username}2"
   name = "${data.coderd_user.ethan.name}2"
   email = "${data.coderd_user.ethan.email}.au"
-  login_type = "${data.coderd_user.ethan.login_type}"
   roles = data.coderd_user.ethan.roles
   suspended = data.coderd_user.ethan.suspended
 }
diff --git a/internal/provider/user_resource.go b/internal/provider/user_resource.go
@@ -76,6 +76,7 @@ func (r *UserResource) Schema(ctx context.Context, req resource.SchemaRequest, r
 				MarkdownDescription: "Display name of the user. Defaults to username.",
 				Required:            false,
 				Optional:            true,
+				// Defaulted in Create
 			},
 			"email": schema.StringAttribute{
 				MarkdownDescription: "Email address of the user.",
@@ -167,6 +168,10 @@ func (r *UserResource) Create(ctx context.Context, req resource.CreateRequest, r
 	if data.LoginType.ValueString() != "" {
 		loginType = codersdk.LoginType(data.LoginType.ValueString())
 	}
+	if loginType == codersdk.LoginTypePassword && data.Password.ValueString() == "" {
+		resp.Diagnostics.AddError("Data Error", "Password is required when login_type is 'password'")
+		return
+	}
 	user, err := client.CreateUser(ctx, codersdk.CreateUserRequest{
 		Email:          data.Email.ValueString(),
 		Username:       data.Username.ValueString(),
@@ -197,6 +202,7 @@ func (r *UserResource) Create(ctx context.Context, req resource.CreateRequest, r
 		return
 	}
 	tflog.Trace(ctx, "successfully updated user profile")
+	data.Name = types.StringValue(user.Name)
 
 	var roles []string
 	resp.Diagnostics.Append(

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ resource "coderd_user" "ethan2" {`
`25`	`25`	`username = "${data.coderd_user.ethan.username}2"`
`26`	`26`	`name = "${data.coderd_user.ethan.name}2"`
`27`	`27`	`email = "${data.coderd_user.ethan.email}.au"`
`28`		`- login_type = "${data.coderd_user.ethan.login_type}"`
`29`	`28`	`roles = data.coderd_user.ethan.roles`
`30`	`29`	`suspended = data.coderd_user.ethan.suspended`
`31`	`30`	`}`