Axios client for EventSource review feedback

aaronlehmann · aaronlehmann · commit 0fff882de569 · 2025-02-28T13:04:11.000-08:00
diff --git a/src/api-helper.ts b/src/api-helper.ts
@@ -11,7 +11,7 @@ export function errToStr(error: unknown, def: string) {
   } else if (isApiErrorResponse(error)) {
     return error.message
   } else if (error instanceof ErrorEvent) {
-    return error.code ? `${error.code}: ${error.message}` : error.message?.toString() || def
+    return error.code ? `${error.code}: ${error.message || def}` : error.message || def
   } else if (typeof error === "string" && error.trim().length > 0) {
     return error
   }
diff --git a/src/api.ts b/src/api.ts
@@ -127,11 +127,9 @@ export function createStreamingFetchAdapter(axiosInstance: AxiosInstance) {
       },
     })
 
-    const createReader = () => stream.getReader()
-
     return {
       body: {
-        getReader: () => createReader(),
+        getReader: () => stream.getReader(),
       },
       url: urlStr,
       status: response.status,

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export function errToStr(error: unknown, def: string) {`
`11`	`11`	`} else if (isApiErrorResponse(error)) {`
`12`	`12`	`return error.message`
`13`	`13`	`} else if (error instanceof ErrorEvent) {`
`14`		- return error.code ? `${error.code}: ${error.message}` : error.message?.toString() \|\| def
	`14`	+ return error.code ? `${error.code}: ${error.message \|\| def}` : error.message \|\| def
`15`	`15`	`} else if (typeof error === "string" && error.trim().length > 0) {`
`16`	`16`	`return error`
`17`	`17`	`}`