fix: resolve lint warnings

brettkolodny · brettkolodny · commit 8974e8bfc88c · 2025-04-01T18:39:12.000-04:00
diff --git a/src/extension.ts b/src/extension.ts
@@ -7,15 +7,15 @@ import { makeCoderSdk, needToken } from "./api"
 import { errToStr } from "./api-helper"
 import { Commands } from "./commands"
 import { CertificateError, getErrorDetail } from "./error"
+import { getMemoryLogger } from "./memoryLogger"
 import { Remote } from "./remote"
 import { Storage } from "./storage"
 import { toSafeHost } from "./util"
 import { WorkspaceQuery, WorkspaceProvider } from "./workspacesProvider"
-import { getMemoryLogger } from "./memoryLogger"
 
 export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
   // Initialize the memory logger right when the extension starts.
-  const logger = getMemoryLogger();
+  const logger = getMemoryLogger()
   await logger.initLogFile(ctx.globalStorageUri.fsPath)
 
   // Log initial memory usage and activation
@@ -26,7 +26,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
   ctx.subscriptions.push({ dispose: () => logger.dispose() })
 
   // Log extension mode
-  logger.info(`Extension mode: ${extensionModeToString(ctx.extensionMode)}`);
+  logger.info(`Extension mode: ${extensionModeToString(ctx.extensionMode)}`)
 
   // The Remote SSH extension's proposed APIs are used to override the SSH host
   // name in VS Code itself. It's visually unappealing having a lengthy name!
@@ -44,9 +44,9 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
     vscode.window.showErrorMessage("Remote SSH extension not found, cannot activate Coder extension")
     throw new Error("Remote SSH extension not found")
   }
-  
-  logger.info(`Found Remote SSH extension: ${remoteSSHExtension.id}`);  
-  
+
+  logger.info(`Found Remote SSH extension: ${remoteSSHExtension.id}`)
+
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const vscodeProposed: typeof vscode = (module as any)._load(
     "vscode",
@@ -251,19 +251,19 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 function extensionModeToString(mode: vscode.ExtensionMode): string {
   switch (mode) {
     case vscode.ExtensionMode.Development:
-      return "Development";
+      return "Development"
     case vscode.ExtensionMode.Production:
-      return "Production";
+      return "Production"
     case vscode.ExtensionMode.Test:
-      return "Test";
+      return "Test"
     default:
-      return `Unknown (${mode})`;
+      return `Unknown (${mode})`
   }
 }
 
 // Add deactivation handler to log memory usage on extension shutdown
 export function deactivate(): void {
-  const logger = getMemoryLogger();
-  logger.info("Coder extension deactivating");
-  logger.logMemoryUsage("EXTENSION_DEACTIVATE");
-}
+  const logger = getMemoryLogger()
+  logger.info("Coder extension deactivating")
+  logger.logMemoryUsage("EXTENSION_DEACTIVATE")
+}
diff --git a/src/inbox.ts b/src/inbox.ts
@@ -4,8 +4,8 @@ import { ProxyAgent } from "proxy-agent"
 import * as vscode from "vscode"
 import { WebSocket } from "ws"
 import { errToStr } from "./api-helper"
-import { type Storage } from "./storage"
 import { getMemoryLogger } from "./memoryLogger"
+import { type Storage } from "./storage"
 
 // These are the template IDs of our notifications.
 // Maybe in the future we should avoid hardcoding
diff --git a/src/memoryLogger.ts b/src/memoryLogger.ts
@@ -1,7 +1,7 @@
-import * as vscode from "vscode"
+import * as fs from "fs/promises"
 import * as os from "os"
 import * as path from "path"
-import * as fs from "fs/promises"
+import * as vscode from "vscode"
 
 /**
  * A class for tracking memory usage and logging resource lifecycles
@@ -32,7 +32,9 @@ export class MemoryLogger {
     }
 
     this.logInterval = setInterval(() => {
-      if (this.disposed) return
+      if (this.disposed) {
+        return
+      }
       this.logMemoryUsage("PERIODIC")
       this.logResourceCounts()
     }, intervalMs)
@@ -159,7 +161,9 @@ export class MemoryLogger {
    * Write to log file
    */
   private async writeToLogFile(message: string): Promise<void> {
-    if (!this.logFile) return
+    if (!this.logFile) {
+      return
+    }
 
     try {
       const timestamp = new Date().toISOString()
diff --git a/src/remote.ts b/src/remote.ts
@@ -16,12 +16,12 @@ import { Commands } from "./commands"
 import { featureSetForVersion, FeatureSet } from "./featureSet"
 import { getHeaderCommand } from "./headers"
 import { Inbox } from "./inbox"
+import { getMemoryLogger } from "./memoryLogger"
 import { SSHConfig, SSHValues, mergeSSHConfigValues } from "./sshConfig"
 import { computeSSHProperties, sshSupportsSetEnv } from "./sshSupport"
 import { Storage } from "./storage"
 import { AuthorityPrefix, expandPath, parseRemoteAuthority } from "./util"
 import { WorkspaceMonitor } from "./workspaceMonitor"
-import { getMemoryLogger } from "./memoryLogger"
 
 export interface RemoteDetails extends vscode.Disposable {
   url: string
diff --git a/src/workspacesProvider.ts b/src/workspacesProvider.ts
@@ -11,8 +11,8 @@ import {
   extractAgents,
   errToStr,
 } from "./api-helper"
-import { Storage } from "./storage"
 import { getMemoryLogger } from "./memoryLogger"
+import { Storage } from "./storage"
 
 export enum WorkspaceQuery {
   Mine = "owner:me",
@@ -71,7 +71,7 @@ export class WorkspaceProvider implements vscode.TreeDataProvider<vscode.TreeIte
 
     logger.info(`WorkspaceProvider(${this.getWorkspacesQuery}): Starting workspace fetch`)
     this.fetching = true
-    let fetchStart = Date.now()
+    const fetchStart = Date.now()
 
     // It is possible we called fetchAndRefresh() manually (through the button
     // for example), in which case we might still have a pending refresh that
@@ -348,7 +348,7 @@ function monitorMetadata(agentId: WorkspaceAgent["id"], restClient: Api): AgentW
     logger.error(`Metadata EventSource error for agent: ${agentId}`, error)
 
     // If connection closes permanently, clean up resources
-    if ((error as any).readyState === EventSource.CLOSED) {
+    if (eventSource.readyState === EventSource.CLOSED) {
       logger.info(`Metadata EventSource connection closed for agent: ${agentId}`)
       if (!disposed) {
         watcher.dispose()
