fix csv file validation after import

ousid · ousid · commit f8cc424e14c0 · 2022-09-17T14:16:11.000+01:00
diff --git a/src/Concerns/HasCsvProperties.php b/src/Concerns/HasCsvProperties.php
@@ -54,8 +54,8 @@ public function handleCsvProperties(): array|MessageBag
             Log::warning($exception->getMessage());
 
             return $this->addError(
-                'file_error',
-                __('Your CSV file has error/errors, or is empty. Please check, and try again')
+                'file',
+                __('The file has error/errors, Please check, and try again')
             );
         }
     }
diff --git a/src/Http/Livewire/CsvImporter.php b/src/Http/Livewire/CsvImporter.php
@@ -114,17 +114,20 @@ protected function rules()
 
     protected function setCsvProperties()
     {
+        if (! $this->handleCsvProperties() instanceof MessageBag) {
+            return [
+                $this->fileHeaders,
+                $this->fileRowCount
+            ] = $this->handleCsvProperties();
+        }
+
         $this->withValidator(function (Validator $validator) {
             $validator->after(function ($validator) {
-                if ($this->handleCsvProperties() instanceof MessageBag) {
-                    $validator->errors()->merge(
-                        $this->handleCsvProperties()->getMessages()
-                    );
-                }
+                $validator->errors()->merge(
+                    $this->handleCsvProperties()->getMessages()
+                );
             });
         })->validate();
-
-        [$this->fileHeaders, $this->fileRowCount] = $this->handleCsvProperties();
     }
 
     protected function importCsv()
diff --git a/tests/CsvImporterTest.php b/tests/CsvImporterTest.php
@@ -53,7 +53,7 @@
     ])
         ->set('file', $file)
         ->assertSet('model', $model)
-        ->assertHasErrors(['file_error']);
+        ->assertHasErrors(['file']);
 });
 
 it('throws a validation error if the csv file has duplicate headers', function () {
@@ -70,7 +70,7 @@
     ])
         ->set('file', $file)
         ->assertSet('model', $model)
-        ->assertHasErrors(['file_error']);
+        ->assertHasErrors(['file']);
 });
 
 it('transfers columnsToMap into an associative array', function () {

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,8 @@ public function handleCsvProperties(): array\|MessageBag`
`54`	`54`	`Log::warning($exception->getMessage());`
`55`	`55`
`56`	`56`	`return $this->addError(`
`57`		`- 'file_error',`
`58`		`- __('Your CSV file has error/errors, or is empty. Please check, and try again')`
	`57`	`+ 'file',`
	`58`	`+ __('The file has error/errors, Please check, and try again')`
`59`	`59`	`);`
`60`	`60`	`}`
`61`	`61`	`}`