topcoder-platform#193 - Even for non admin users, set the new attribute value

callmekatootie · callmekatootie · commit 0bde6336a957 · 2020-09-18T20:44:00.000+05:30
diff --git a/src/services/ReviewService.js b/src/services/ReviewService.js
@@ -148,10 +148,10 @@ function * createReview (authUser, entity) {
     if (entity.reviewedDate) {
       throw new errors.HttpStatusError(403, 'You are not allowed to set the `reviewedDate` attribute on a review')
     }
-  } else {
-    item.reviewedDate = entity.reviewedDate || item.created
   }
 
+  item.reviewedDate = entity.reviewedDate || item.created
+
   // Prepare record to be inserted
   const record = {
     TableName: table,
diff --git a/src/services/ReviewSummationService.js b/src/services/ReviewSummationService.js
@@ -106,10 +106,10 @@ function * createReviewSummation (authUser, entity) {
     if (entity.reviewedDate) {
       throw new errors.HttpStatusError(403, 'You are not allowed to set the `reviewedDate` attribute on a review summation')
     }
-  } else {
-    item.reviewedDate = entity.reviewedDate || item.created
   }
 
+  item.reviewedDate = entity.reviewedDate || item.created
+
   const record = {
     TableName: table,
     Item: item
diff --git a/src/services/SubmissionService.js b/src/services/SubmissionService.js
@@ -316,9 +316,10 @@ function * createSubmission (authUser, files, entity) {
     }
   } else {
     logger.info(`No need to call checkCreateAccess for ${JSON.stringify(authUser)}`)
-    item.submittedDate = entity.submittedDate || item.created
   }
 
+  item.submittedDate = entity.submittedDate || item.created
+
   // Prepare record to be inserted
   const record = {
     TableName: table,

Original file line number	Diff line number	Diff line change
`@@ -148,10 +148,10 @@ function * createReview (authUser, entity) {`
`148`	`148`	`if (entity.reviewedDate) {`
`149`	`149`	throw new errors.HttpStatusError(403, 'You are not allowed to set the `reviewedDate` attribute on a review')
`150`	`150`	`}`
`151`		`- } else {`
`152`		`- item.reviewedDate = entity.reviewedDate \|\| item.created`
`153`	`151`	`}`
`154`	`152`
	`153`	`+ item.reviewedDate = entity.reviewedDate \|\| item.created`
	`154`	`+`
`155`	`155`	`// Prepare record to be inserted`
`156`	`156`	`const record = {`
`157`	`157`	`TableName: table,`
Original file line number	Diff line number	Diff line change
`@@ -106,10 +106,10 @@ function * createReviewSummation (authUser, entity) {`
`106`	`106`	`if (entity.reviewedDate) {`
`107`	`107`	throw new errors.HttpStatusError(403, 'You are not allowed to set the `reviewedDate` attribute on a review summation')
`108`	`108`	`}`
`109`		`- } else {`
`110`		`- item.reviewedDate = entity.reviewedDate \|\| item.created`
`111`	`109`	`}`
`112`	`110`
	`111`	`+ item.reviewedDate = entity.reviewedDate \|\| item.created`
	`112`	`+`
`113`	`113`	`const record = {`
`114`	`114`	`TableName: table,`
`115`	`115`	`Item: item`
Original file line number	Diff line number	Diff line change
`@@ -316,9 +316,10 @@ function * createSubmission (authUser, files, entity) {`
`316`	`316`	`}`
`317`	`317`	`} else {`
`318`	`318`	logger.info(`No need to call checkCreateAccess for ${JSON.stringify(authUser)}`)
`319`		`- item.submittedDate = entity.submittedDate \|\| item.created`
`320`	`319`	`}`
`321`	`320`
	`321`	`+ item.submittedDate = entity.submittedDate \|\| item.created`
	`322`	`+`
`322`	`323`	`// Prepare record to be inserted`
`323`	`324`	`const record = {`
`324`	`325`	`TableName: table,`