fix($compile): handle boolean attributes in @ bindings

jannic · gkalpak · commit 1cb8d529a652 · 2016-04-09T16:52:33.000+03:00
Commit db5e0ff handles initial values of boolean attributes. The same change needs to be applied inside the attrs.$observe() call. Closes angular#14070
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -3122,7 +3122,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
               destination[scopeName] = attrs[attrName] = void 0;
             }
             attrs.$observe(attrName, function(value) {
-              if (isString(value)) {
+              if (isString(value) || isBoolean(value)) {
                 var oldValue = destination[scopeName];
                 recordChanges(scopeName, value, oldValue);
                 destination[scopeName] = value;
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -2712,6 +2712,25 @@ describe('$compile', function() {
                 expect(checkedVal).toEqual(true);
               });
             });
+
+            it('should handle updates to @ bindings on BOOLEAN attributes', function() {
+              var componentScope;
+              module(function($compileProvider) {
+                $compileProvider.directive('test', function() {
+                  return {
+                    scope: {checked: '@'},
+                    link: function(scope, element, attrs) {
+                      componentScope = scope;
+                      attrs.$set('checked', true);
+                    }
+                  };
+                });
+              });
+              inject(function($compile, $rootScope) {
+                $compile('<test></test>')($rootScope);
+                expect(componentScope.checked).toBe(true);
+              });
+            });
           });
 
 

Original file line number	Diff line number	Diff line change
`@@ -3122,7 +3122,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {`
`3122`	`3122`	`destination[scopeName] = attrs[attrName] = void 0;`
`3123`	`3123`	`}`
`3124`	`3124`	`attrs.$observe(attrName, function(value) {`
`3125`		`- if (isString(value)) {`
	`3125`	`+ if (isString(value) \|\| isBoolean(value)) {`
`3126`	`3126`	`var oldValue = destination[scopeName];`
`3127`	`3127`	`recordChanges(scopeName, value, oldValue);`
`3128`	`3128`	`destination[scopeName] = value;`