fix(ngClass): fix watching of an array expression containing an object

drpicox · gkalpak · commit 74eb4684dce1 · 2016-04-11T12:38:45.000+03:00
Closes angular#14405
diff --git a/src/ng/directive/ngClass.js b/src/ng/directive/ngClass.js
@@ -78,7 +78,11 @@ function classDirective(name, selector) {
               updateClasses(oldClasses, newClasses);
             }
           }
-          oldVal = shallowCopy(newVal);
+          if (isArray(newVal)) {
+            oldVal = newVal.map(function(v) { return shallowCopy(v); });
+          } else {
+            oldVal = shallowCopy(newVal);
+          }
         }
       }
     };
diff --git a/test/ng/directive/ngClassSpec.js b/test/ng/directive/ngClassSpec.js
@@ -409,6 +409,22 @@ describe('ngClass', function() {
     expect(e2.hasClass('even')).toBeTruthy();
     expect(e2.hasClass('odd')).toBeFalsy();
   }));
+
+  it('should support mixed array/object variable with a mutating object',
+    inject(function($rootScope, $compile) {
+      element = $compile('<div ng-class="classVar"></div>')($rootScope);
+
+      $rootScope.classVar = [{orange: true}];
+      $rootScope.$digest();
+      expect(element).toHaveClass('orange');
+
+      $rootScope.classVar[0].orange = false;
+      $rootScope.$digest();
+
+      expect(element).not.toHaveClass('orange');
+    })
+  );
+
 });
 
 describe('ngClass animations', function() {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,11 @@ function classDirective(name, selector) {`
`78`	`78`	`updateClasses(oldClasses, newClasses);`
`79`	`79`	`}`
`80`	`80`	`}`
`81`		`- oldVal = shallowCopy(newVal);`
	`81`	`+ if (isArray(newVal)) {`
	`82`	`+ oldVal = newVal.map(function(v) { return shallowCopy(v); });`
	`83`	`+ } else {`
	`84`	`+ oldVal = shallowCopy(newVal);`
	`85`	`+ }`
`82`	`86`	`}`
`83`	`87`	`}`
`84`	`88`	`};`