perf(copy): avoid regex in isTypedArray

jbedard · petebacondarwin · commit a9ecde1e33c1 · 2015-11-19T10:00:37.000Z
Closes: angular#12054
diff --git a/src/Angular.js b/src/Angular.js
@@ -609,9 +609,9 @@ function isPromiseLike(obj) {
 }
 
 
-var TYPED_ARRAY_REGEXP = /^\[object (Uint8(Clamped)?)|(Uint16)|(Uint32)|(Int8)|(Int16)|(Int32)|(Float(32)|(64))Array\]$/;
+var TYPED_ARRAY_REGEXP = /^\[object (?:Uint8|Uint8Clamped|Uint16|Uint32|Int8|Int16|Int32|Float32|Float64)Array\]$/;
 function isTypedArray(value) {
-  return TYPED_ARRAY_REGEXP.test(toString.call(value));
+  return value && isNumber(value.length) && TYPED_ARRAY_REGEXP.test(toString.call(value));
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -609,9 +609,9 @@ function isPromiseLike(obj) {`
`609`	`609`	`}`
`610`	`610`
`611`	`611`
`612`		`-var TYPED_ARRAY_REGEXP = /^\[object (Uint8(Clamped)?)\|(Uint16)\|(Uint32)\|(Int8)\|(Int16)\|(Int32)\|(Float(32)\|(64))Array\]$/;`
	`612`	`+var TYPED_ARRAY_REGEXP = /^\[object (?:Uint8\|Uint8Clamped\|Uint16\|Uint32\|Int8\|Int16\|Int32\|Float32\|Float64)Array\]$/;`
`613`	`613`	`function isTypedArray(value) {`
`614`		`- return TYPED_ARRAY_REGEXP.test(toString.call(value));`
	`614`	`+ return value && isNumber(value.length) && TYPED_ARRAY_REGEXP.test(toString.call(value));`
`615`	`615`	`}`
`616`	`616`
`617`	`617`