chore(build): add a validation step for angularFiles

matsko · petebacondarwin · commit d2058d92bd6f · 2015-12-17T22:29:28.000Z
Closes angular#13553
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -4,7 +4,9 @@ var files = require('./angularFiles').files;
 var util = require('./lib/grunt/utils.js');
 var versionInfo = require('./lib/versions/version-info');
 var path = require('path');
+var fs = require('fs');
 var e2e = require('./test/e2e/tools');
+var glob = require("glob");
 
 module.exports = function(grunt) {
   //grunt plugins
@@ -327,6 +329,56 @@ module.exports = function(grunt) {
     grunt.task.run('shell:npm-install');
   }
 
+  grunt.registerTask('validate-angular-files', function() {
+    var combinedFiles = Object.assign({}, files.angularModules);
+    combinedFiles.ng = files.angularSrc;
+    combinedFiles.angularLoader = files.angularLoader;
+
+    var errorsDetected = false;
+    var directories = [];
+    var detectedFiles = {
+      "src/ng/rootElement.js": true
+    };
+
+    for (var section in combinedFiles) {
+      var sectionFiles = combinedFiles[section];
+
+      if (section != "angularLoader") {
+        directories.push("src/" + section);
+      }
+
+      console.log("Validating " + sectionFiles.length + " files from the \"" + section + "\" module");
+
+      sectionFiles.forEach(function(file) {
+        detectedFiles[file] = true;
+
+        if (!fs.existsSync(file)) {
+          grunt.log.error(file + " does not exist in the local file structure");
+          errorsDetected = true;
+        }
+      });
+    }
+
+    directories.forEach(function(directory) {
+      glob.sync(directory + "/**/*").forEach(function(filePath) {
+        if (!fs.lstatSync(filePath).isDirectory()) {
+          var fileName = path.basename(filePath);
+          var isHiddenFile = fileName[0] == ".";
+          if (!isHiddenFile && !detectedFiles[filePath]) {
+            grunt.log.error(filePath + " exists in the local file structure but isn't used by any module");
+            errorsDetected = true;
+          }
+        }
+      });
+    });
+
+    if (errorsDetected) {
+      throw new Error("Not all files were properly detected the local file structure");
+    } else {
+      console.log("All files were detected successfully!");
+    }
+  });
+
   //alias tasks
   grunt.registerTask('test', 'Run unit, docs and e2e tests with Karma', ['jshint', 'jscs', 'package','test:unit','test:promises-aplus', 'tests:docs', 'test:protractor']);
   grunt.registerTask('test:jqlite', 'Run the unit tests with Karma' , ['tests:jqlite']);
@@ -342,7 +394,7 @@ module.exports = function(grunt) {
 
   grunt.registerTask('minify', ['bower','clean', 'build', 'minall']);
   grunt.registerTask('webserver', ['connect:devserver']);
-  grunt.registerTask('package', ['bower','clean', 'buildall', 'minall', 'collect-errors', 'docs', 'copy', 'write', 'compress']);
+  grunt.registerTask('package', ['bower', 'validate-angular-files','clean', 'buildall', 'minall', 'collect-errors', 'docs', 'copy', 'write', 'compress']);
   grunt.registerTask('ci-checks', ['ddescribe-iit', 'merge-conflict', 'jshint', 'jscs']);
   grunt.registerTask('default', ['package']);
 };
diff --git a/angularFiles.js b/angularFiles.js
@@ -79,7 +79,7 @@ var angularFiles = {
   ],
 
   'angularLoader': [
-    'stringify.js',
+    'src/stringify.js',
     'src/minErr.js',
     'src/loader.js'
   ],
