Use vscode.open instead of the opn package (LeetCode-OpenSource#90)

jdneo · web-flow · commit 424ba0c3cd87 · 2019-01-13T19:29:08.000+08:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -258,7 +258,6 @@
     },
     "dependencies": {
         "fs-extra": "^6.0.1",
-        "leetcode-cli": "2.6.1",
-        "opn": "^5.2.0"
+        "leetcode-cli": "2.6.1"
     }
 }
diff --git a/src/leetCodeExecutor.ts b/src/leetCodeExecutor.ts
@@ -2,11 +2,10 @@
 // Licensed under the MIT license.
 
 import * as cp from "child_process";
-import * as opn from "opn";
 import * as path from "path";
 import * as vscode from "vscode";
 import { executeCommand, executeCommandWithProgress } from "./utils/cpUtils";
-import { DialogOptions } from "./utils/uiUtils";
+import { DialogOptions, openUrl } from "./utils/uiUtils";
 import * as wsl from "./utils/wslUtils";
 
 class LeetCodeExecutor {
@@ -38,7 +37,7 @@ class LeetCodeExecutor {
                 DialogOptions.open,
             );
             if (choice === DialogOptions.open) {
-                opn("https://nodejs.org");
+                openUrl("https://nodejs.org");
             }
             return false;
         }
diff --git a/src/utils/uiUtils.ts b/src/utils/uiUtils.ts
@@ -1,7 +1,6 @@
 // Copyright (c) jdneo. All rights reserved.
 // Licensed under the MIT license.
 
-import * as opn from "opn";
 import * as vscode from "vscode";
 import { isLeetCodeCnEnabled } from "../commands/plugin";
 import { leetCodeChannel } from "../leetCodeChannel";
@@ -48,9 +47,9 @@ export async function promptForSignIn(): Promise<void> {
             break;
         case DialogOptions.singUp:
             if (isLeetCodeCnEnabled()) {
-                opn("https://leetcode-cn.com");
+                openUrl("https://leetcode-cn.com");
             } else {
-                opn("https://leetcode.com");
+                openUrl("https://leetcode.com");
             }
             break;
         default:
@@ -70,6 +69,10 @@ export async function showFileSelectDialog(): Promise<vscode.Uri[] | undefined>
     return await vscode.window.showOpenDialog(options);
 }
 
+export async function openUrl(url: string): Promise<void> {
+    vscode.commands.executeCommand("vscode.open", vscode.Uri.parse(url));
+}
+
 export enum DialogType {
     info = "info",
     warning = "warning",

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,6 @@`
`258`	`258`	`},`
`259`	`259`	`"dependencies": {`
`260`	`260`	`"fs-extra": "^6.0.1",`
`261`		`- "leetcode-cli": "2.6.1",`
`262`		`- "opn": "^5.2.0"`
	`261`	`+ "leetcode-cli": "2.6.1"`
`263`	`262`	`}`
`264`	`263`	`}`