Fixed glob includes for ignore_root_user_error (bazel-contrib#1037)

linzhp · web-flow · commit 0e55ced05fa4 · 2023-02-01T19:17:20.000-08:00
diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
@@ -273,3 +273,24 @@ tasks:
     name: pip_repository_entry_points integration tests on Windows
     working_directory: tests/pip_repository_entry_points
     platform: windows
+
+  integration_test_ignore_root_user_error_ubuntu:
+    <<: *reusable_build_test_all
+    name: ignore_root_user_error integration tests on Ubuntu
+    working_directory: tests/ignore_root_user_error
+    platform: ubuntu2004
+  integration_test_ignore_root_user_error_debian:
+    <<: *reusable_build_test_all
+    name: ignore_root_user_error integration tests on Debian
+    working_directory: tests/ignore_root_user_error
+    platform: debian11
+  integration_test_ignore_root_user_error_macos:
+    <<: *reusable_build_test_all
+    name: ignore_root_user_error integration tests on macOS
+    working_directory: tests/ignore_root_user_error
+    platform: macos
+  integration_test_ignore_root_user_error_windows:
+    <<: *reusable_build_test_all
+    name: ignore_root_user_error integration tests on Windows
+    working_directory: tests/ignore_root_user_error
+    platform: windows
diff --git a/tests/ignore_root_user_error/.bazelrc b/tests/ignore_root_user_error/.bazelrc
@@ -0,0 +1,5 @@
+test --test_output=errors
+
+# Windows requires these for multi-python support:
+build --enable_runfiles
+startup --windows_enable_symlinks
diff --git a/tests/ignore_root_user_error/.gitignore b/tests/ignore_root_user_error/.gitignore
@@ -0,0 +1 @@
+bazel-*
diff --git a/tests/ignore_root_user_error/BUILD.bazel b/tests/ignore_root_user_error/BUILD.bazel
@@ -0,0 +1,7 @@
+load("@rules_python//python:defs.bzl", "py_test")
+
+py_test(
+    name = "foo_test",
+    srcs = ["foo_test.py"],
+    visibility = ["//visibility:public"],
+)
diff --git a/tests/ignore_root_user_error/README.md b/tests/ignore_root_user_error/README.md
@@ -0,0 +1,2 @@
+# ignore_root_user_errors
+There are cases when we have to run Python targets with root, e.g., in Docker containers, requiring setting `ignore_root_user_error = True` when registering Python toolchain. This test makes sure that rules_python works in this case.
diff --git a/tests/ignore_root_user_error/WORKSPACE b/tests/ignore_root_user_error/WORKSPACE
@@ -0,0 +1,12 @@
+local_repository(
+    name = "rules_python",
+    path = "../..",
+)
+
+load("@rules_python//python:repositories.bzl", "python_register_toolchains")
+
+python_register_toolchains(
+    name = "python39",
+    ignore_root_user_error = True,
+    python_version = "3.9",
+)
diff --git a/tests/ignore_root_user_error/foo_test.py b/tests/ignore_root_user_error/foo_test.py
@@ -0,0 +1,13 @@
+# Copyright 2019 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+# ignore_root_user_errors`
	`2`	+There are cases when we have to run Python targets with root, e.g., in Docker containers, requiring setting `ignore_root_user_error = True` when registering Python toolchain. This test makes sure that rules_python works in this case.