Revert "Add option to use "pip download" instead of "pip wheel" to do… (bazel-contrib#808)

groodt · web-flow · commit 4999f631c2af · 2022-08-28T06:14:46.000+10:00
Revert "Add option to use "pip download" instead of "pip wheel" to download wheels for other platforms (bazel-contrib#773)" This reverts commit 6a43ebd.
diff --git a/docs/pip_repository.md b/docs/pip_repository.md
diff --git a/examples/pip_parse_vendored/requirements.bzl b/examples/pip_parse_vendored/requirements.bzl
@@ -12,7 +12,7 @@ all_requirements = ["@pip_certifi//:pkg", "@pip_charset_normalizer//:pkg", "@pip
 all_whl_requirements = ["@pip_certifi//:whl", "@pip_charset_normalizer//:whl", "@pip_idna//:whl", "@pip_requests//:whl", "@pip_urllib3//:whl"]
 
 _packages = [("pip_certifi", "certifi==2021.10.8     --hash=sha256:78884e7c1d4b00ce3cea67b44566851c4343c120abd683433ce934a68ea58872     --hash=sha256:d62a0163eb4c2344ac042ab2bdf75399a71a2d8c7d47eac2e2ee91b9d6339569"), ("pip_charset_normalizer", "charset-normalizer==2.0.12     --hash=sha256:2857e29ff0d34db842cd7ca3230549d1a697f96ee6d3fb071cfa6c7393832597     --hash=sha256:6881edbebdb17b39b4eaaa821b438bf6eddffb4468cf344f09f89def34a8b1df"), ("pip_idna", "idna==3.3     --hash=sha256:84d9dd047ffa80596e0f246e2eab0b391788b0503584e8945f2368256d2735ff     --hash=sha256:9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"), ("pip_requests", "requests==2.27.1     --hash=sha256:68d7c56fd5a8999887728ef304a6d12edc7be74f1cfa47714fc8b414525c9a61     --hash=sha256:f22fa1e554c9ddfd16e6e41ac79759e17be9e492b3587efa038054674760e72d"), ("pip_urllib3", "urllib3==1.26.9     --hash=sha256:44ece4d53fb1706f667c9bd1c648f5469a2ec925fcf3a776667042d645472c14     --hash=sha256:aabaf16477806a5e1dd19aa41f8c2b7950dd3c746362d7e3223dbe6de6ac448e")]
-_config = {"download_only": False, "enable_implicit_namespace_pkgs": False, "environment": {}, "extra_pip_args": [], "isolated": True, "pip_data_exclude": [], "python_interpreter": "python3", "python_interpreter_target": interpreter, "quiet": True, "repo": "pip", "repo_prefix": "pip_", "timeout": 600}
+_config = {"enable_implicit_namespace_pkgs": False, "environment": {}, "extra_pip_args": [], "isolated": True, "pip_data_exclude": [], "python_interpreter": "python3", "python_interpreter_target": interpreter, "quiet": True, "repo": "pip", "repo_prefix": "pip_", "timeout": 600}
 _annotations = {}
 
 def _clean_name(name):
diff --git a/python/pip_install/extract_wheels/arguments.py b/python/pip_install/extract_wheels/arguments.py
@@ -39,12 +39,6 @@ def parse_common_args(parser: ArgumentParser) -> ArgumentParser:
         required=True,
         help="Prefix to prepend to packages",
     )
-    parser.add_argument(
-        "--download_only",
-        action="store_true",
-        help="Use 'pip download' instead of 'pip wheel'. Disables building wheels from source, but allows use of "
-             "--platform, --python-version, --implementation, and --abi in --extra_pip_args.",
-    )
     return parser
 
 
diff --git a/python/pip_install/extract_wheels/extract_single_wheel.py b/python/pip_install/extract_wheels/extract_single_wheel.py
@@ -38,7 +38,7 @@ def main() -> None:
     pip_args = (
         [sys.executable, "-m", "pip"]
         + (["--isolated"] if args.isolated else [])
-        + ["download" if args.download_only else "wheel", "--no-deps"]
+        + ["wheel", "--no-deps"]
         + deserialized_args["extra_pip_args"]
     )
 
diff --git a/python/pip_install/extract_wheels/extract_wheels.py b/python/pip_install/extract_wheels/extract_wheels.py
@@ -80,7 +80,7 @@ def main() -> None:
     pip_args = (
         [sys.executable, "-m", "pip"]
         + (["--isolated"] if args.isolated else [])
-        + ["download" if args.download_only else "wheel", "-r", args.requirements]
+        + ["wheel", "-r", args.requirements]
         + ["--wheel-dir", os.getcwd()]
         + deserialized_args["extra_pip_args"]
     )
diff --git a/python/pip_install/pip_repository.bzl b/python/pip_install/pip_repository.bzl
@@ -130,9 +130,6 @@ def _parse_optional_attrs(rctx, args):
             struct(arg = rctx.attr.extra_pip_args).to_json(),
         ]
 
-    if rctx.attr.download_only:
-        args.append("--download_only")
-
     if rctx.attr.pip_data_exclude != None:
         args += [
             "--pip_data_exclude",
@@ -253,13 +250,6 @@ common_env = [
 ]
 
 common_attrs = {
-    "download_only": attr.bool(
-        doc = """
-Whether to use "pip download" instead of "pip wheel". Disables building wheels from source, but allows use of
---platform, --python-version, --implementation, and --abi in --extra_pip_args to download wheels for a different
-platform from the host platform.
-        """,
-    ),
     "enable_implicit_namespace_pkgs": attr.bool(
         default = False,
         doc = """

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ def main() -> None:`
`38`	`38`	`pip_args = (`
`39`	`39`	`[sys.executable, "-m", "pip"]`
`40`	`40`	`+ (["--isolated"] if args.isolated else [])`
`41`		`- + ["download" if args.download_only else "wheel", "--no-deps"]`
	`41`	`+ + ["wheel", "--no-deps"]`
`42`	`42`	`+ deserialized_args["extra_pip_args"]`
`43`	`43`	`)`
`44`	`44`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ def main() -> None:`
`80`	`80`	`pip_args = (`
`81`	`81`	`[sys.executable, "-m", "pip"]`
`82`	`82`	`+ (["--isolated"] if args.isolated else [])`
`83`		`- + ["download" if args.download_only else "wheel", "-r", args.requirements]`
	`83`	`+ + ["wheel", "-r", args.requirements]`
`84`	`84`	`+ ["--wheel-dir", os.getcwd()]`
`85`	`85`	`+ deserialized_args["extra_pip_args"]`
`86`	`86`	`)`