fix(platforms): include flag_values in config_settings (bazel-contrib#2236)

aignas · web-flow · commit 93eda704fe25 · 2024-09-22T04:37:45.000Z
This function that allows us to generate config settings for
supported platforms did not get the flag_values addition.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -60,6 +60,8 @@ A brief description of the categories of changes:
   in extra_requires in py_wheel rule.
 * (rules) Prevent pytest from trying run the generated stage2
   bootstrap .py file when using {obj}`--bootstrap_impl=script`
+* (toolchain) The {bzl:obj}`gen_python_config_settings` has been fixed to include
+  the flag_values from the platform definitions.
 
 
 ### Added
diff --git a/python/versions.bzl b/python/versions.bzl
@@ -722,5 +722,6 @@ def gen_python_config_settings(name = ""):
     for platform in PLATFORMS.keys():
         native.config_setting(
             name = "{name}{platform}".format(name = name, platform = platform),
+            flag_values = PLATFORMS[platform].flag_values,
             constraint_values = PLATFORMS[platform].compatible_with,
         )

Original file line number	Diff line number	Diff line change
`@@ -722,5 +722,6 @@ def gen_python_config_settings(name = ""):`
`722`	`722`	`for platform in PLATFORMS.keys():`
`723`	`723`	`native.config_setting(`
`724`	`724`	`name = "{name}{platform}".format(name = name, platform = platform),`
	`725`	`+ flag_values = PLATFORMS[platform].flag_values,`
`725`	`726`	`constraint_values = PLATFORMS[platform].compatible_with,`
`726`	`727`	`)`