fix: allow accented letters in author name (#221)

kohanyirobert · web-flow · commit a237cda9cd94 · 2025-02-24T01:00:11.000+08:00
* fix: allow accented letters in author name

Allow accented letters (e.g. áéó, etc.) in an
author's name.

* fix: remove duplicate unicode regex range

* fix: add broader regex range to .yml as well

* fix: remove duplicate regex key
diff --git a/.commit-check.yml b/.commit-check.yml
@@ -14,7 +14,7 @@ checks:
     suggest: run command `git checkout -b type/branch_name`
 
   - check: author_name
-    regex: ^[A-Za-z ,.\'-]+$|.*(\[bot])
+    regex: ^[A-Za-zÀ-ÖØ-öø-ÿ\u0100-\u017F\u0180-\u024F ,.\'-]+$|.*(\[bot])
     error: The committer name seems invalid
     suggest: run command `git config user.name "Your Name"`
 
diff --git a/commit_check/__init__.py b/commit_check/__init__.py
@@ -32,7 +32,7 @@
         },
         {
             'check': 'author_name',
-            'regex': r'^[A-Za-z ,.\'-]+$|.*(\[bot])',
+            'regex': r'^[A-Za-zÀ-ÖØ-öø-ÿ\u0100-\u017F\u0180-\u024F ,.\'-]+$|.*(\[bot])',
             'error': 'The committer name seems invalid',
             'suggest': 'run command `git config user.name "Your Name"`',
         },
diff --git a/tests/author_test.py b/tests/author_test.py
@@ -9,6 +9,7 @@ class TestAuthor:
     class TestAuthorName:
         # used by get_commit_info mock
         fake_author_value_an = "fake_author_name"
+        fake_accented_author_value_an = "fáké_áúthór_námé"
 
         def test_check_author(self, mocker):
             # Must call get_commit_info, re.match.
@@ -29,6 +30,25 @@ def test_check_author(self, mocker):
             assert m_get_commit_info.call_count == 1
             assert m_re_match.call_count == 1
 
+        def test_check_author_with_accented_letters(self, mocker):
+            # Must call get_commit_info, re.match.
+            checks = [{
+                "check": "author_name",
+                "regex": "dummy_regex"
+            }]
+            m_get_commit_info = mocker.patch(
+                f"{LOCATION}.get_commit_info",
+                return_value=self.fake_accented_author_value_an
+            )
+            m_re_match = mocker.patch(
+                "re.match",
+                return_value="fake_rematch_resp"
+            )
+            retval = check_author(checks, "author_name")
+            assert retval == PASS
+            assert m_get_commit_info.call_count == 1
+            assert m_re_match.call_count == 1
+
         def test_check_author_with_empty_checks(self, mocker):
             # Must NOT call get_commit_info, re.match. with `checks` param with length 0.
             checks = []

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`},`
`33`	`33`	`{`
`34`	`34`	`'check': 'author_name',`
`35`		`- 'regex': r'^[A-Za-z ,.\'-]+$\|.*(\[bot])',`
	`35`	`+ 'regex': r'^[A-Za-zÀ-ÖØ-öø-ÿ\u0100-\u017F\u0180-\u024F ,.\'-]+$\|.*(\[bot])',`
`36`	`36`	`'error': 'The committer name seems invalid',`
`37`	`37`	'suggest': 'run command `git config user.name "Your Name"`',
`38`	`38`	`},`