From 7667640f745efbcd772b0433e0d9c9684cfc2939 Mon Sep 17 00:00:00 2001 From: shenxianpeng Date: Mon, 3 Feb 2025 09:01:33 +0000 Subject: [PATCH] refactor: consider early return optimization for dry-run --- commit_check/main.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/commit_check/main.py b/commit_check/main.py index c6b8b32..6faa070 100644 --- a/commit_check/main.py +++ b/commit_check/main.py @@ -99,6 +99,10 @@ def main() -> int: """The main entrypoint of commit-check program.""" parser = get_parser() args = parser.parse_args() + + if args.dry_run: + return PASS + check_results: list[int] = [] with error_handler(): @@ -119,9 +123,6 @@ def main() -> int: if args.merge_base: check_results.append(branch.check_merge_base(checks)) - if args.dry_run: - return PASS - return PASS if all(val == PASS for val in check_results) else FAIL pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy