refactor(git): retype get_commits parameter to make it more friendly to call sites

bearomorphism · Lee-W · commit 654f4a03b34c · 2025-06-09T23:18:04.000+09:00
diff --git a/commitizen/commands/bump.py b/commitizen/commands/bump.py
@@ -253,10 +253,7 @@ def __call__(self) -> None:
                 ) from exc
         else:
             if increment is None:
-                if current_tag:
-                    commits = git.get_commits(current_tag.name)
-                else:
-                    commits = git.get_commits()
+                commits = git.get_commits(current_tag.name if current_tag else None)
 
                 # No commits, there is no need to create an empty tag.
                 # Unless we previously had a prerelease.
diff --git a/commitizen/commands/check.py b/commitizen/commands/check.py
@@ -110,7 +110,7 @@ def _get_commits(self) -> list[git.GitCommit]:
             return [git.GitCommit(rev="", title="", body=self._filter_comments(msg))]
 
         # Get commit messages from git log (--rev-range)
-        return git.get_commits(end=self.rev_range or "HEAD")
+        return git.get_commits(end=self.rev_range)
 
     @staticmethod
     def _filter_comments(msg: str) -> str:
diff --git a/commitizen/git.py b/commitizen/git.py
@@ -201,15 +201,18 @@ def _create_commit_cmd_string(args: str, committer_date: str | None, name: str)
 
 def get_commits(
     start: str | None = None,
-    end: str = "HEAD",
+    end: str | None = None,
     *,
     args: str = "",
 ) -> list[GitCommit]:
     """Get the commits between start and end."""
+    if end is None:
+        end = "HEAD"
     git_log_entries = _get_log_as_str_list(start, end, args)
     return [
         GitCommit.from_rev_and_commit(rev_and_commit)
-        for rev_and_commit in filter(None, git_log_entries)
+        for rev_and_commit in git_log_entries
+        if rev_and_commit
     ]
 
 
