Skip to content

Fix type definition issues in the constructors #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

milindl
Copy link
Contributor

@milindl milindl commented May 22, 2025

No description provided.

davidkhala and others added 2 commits May 22, 2025 08:58
constructor config mark as optional properly
@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 05:07
@milindl milindl requested review from a team as code owners May 22, 2025 05:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the changelog to document the fix for type definition issues in the Kafka constructor and topic configuration parameters for the promisified API.

  • Updated changelog entry to reflect changes in type definitions for Kafka() and the promisified API.

@milindl milindl requested a review from Copilot May 22, 2025 05:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses type definition issues in the constructors by updating the changelog to reflect fixes.

  • Updated changelog entry to include fixes for the Kafka() constructor and adjustments to topic configuration handling in the producer() and consumer() methods.

@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (71.80% Estimated after merge)
  • Duplications No duplication information (2.00% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@milindl milindl merged commit 2e7774c into master May 22, 2025
3 checks passed
@milindl milindl deleted the dev_fix_type_issues branch May 22, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy