Skip to content

Update 1.4.0 release candidate #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 3, 2025
Merged

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Jul 3, 2025

Changes to windows installation for API calls to confirm to published guidelines.

Successful ci run: https://semaphore.ci.confluent.io/workflows/449d7e4f-f135-44b3-a5c5-b6d1c02de747?pipeline_id=3401de02-f22a-4a61-8e37-b15b3edb7d1f

@milindl milindl requested review from a team as code owners July 3, 2025 10:12
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@milindl
Copy link
Contributor Author

milindl commented Jul 3, 2025

@sonarqube-confluent
Copy link

Failed

  • 25.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 25.00% Coverage (70.30% Estimated after merge)
  • Duplications No duplication information (2.00% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Milind!

@milindl milindl merged commit dbd0b6a into node-v24 Jul 3, 2025
2 of 3 checks passed
@milindl milindl deleted the update_1.4.0-release-candidate branch July 3, 2025 14:30
milindl added a commit that referenced this pull request Jul 3, 2025
* feat: add support for Node v24

Updated `semaphore.yml ` to add support for Node.js v24.  Used the ABI version as listed in the JSON file located at: 
https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json

* Update post-install and README for v24

* Add CHANGELOG, update SR tests to pass

* Revert testing only changes

* Update changelog

* Revert more testing-only changes

* Update 1.4.0 release candidate (#341)

* Bump version to 1.4.0-rc0

* Use publicly documented API to download librdkafka NuGet package

* Fix librdkafka version

* Conform to nuget API

* Update so that changes are not -dev

* Update to RC4 of librdkafka

* Add testing changes

* Revert testing changes

---------

Co-authored-by: Weyert de Boer <weyert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy