Update for 1.4.0 #342
Merged
Update for 1.4.0 #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the released version from 1.4.0-rc0 to 1.4.0 across packages and updates the librdkafka dependency and CI checkout to the stable 2.11.0 tag.
- Updated package versions in
package.jsonandschemaregistry/package.json - Updated
util.bindingVersionand generated header comment inlib/util.jsandlib/error.js - Updated CI pipeline to checkout the stable
librdkafkatag in.semaphore/semaphore.yml
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schemaregistry/package.json | Bump schema registry package version to 1.4.0 |
| package.json | Bump kafka-javascript version to 1.4.0 and librdkafka dependency to 2.11.0 |
| lib/util.js | Updated util.bindingVersion to 1.4.0 |
| lib/error.js | Updated generated header comment to reference 2.11.0 |
| .semaphore/semaphore.yml | Checkout stable v2.11.0 instead of release candidate |
Comments suppressed due to low confidence (2)
package.json:3
- Please update the CHANGELOG.md (or release notes) to include details about the 1.4.0 release.
"version": "1.4.0",
package.json:5
- Don't forget to regenerate or update the lock file (package-lock.json or yarn.lock) so it pins the new librdkafka version.
"librdkafka": "2.11.0",
| @@ -52,4 +52,4 @@ util.dictToStringList = function (mapOrObject) { | |||
| return list; | |||
| }; | |||
|
|
|||
| util.bindingVersion = '1.4.0-rc0'; | |||
| util.bindingVersion = '1.4.0'; | |||
There was a problem hiding this comment.
[nitpick] Consider sourcing the binding version dynamically from package.json to avoid duplicating the version string in code.
Copilot uses AI. Check for mistakes.
This comment has been minimized.
This comment has been minimized.
emasab
approved these changes
Jul 3, 2025
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version and librdkafka version