v2.10.1 #1995
v2.10.1 #1995
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
Can you confirm that all the steps mentioned in the release doc is working fine with RC? |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project from the 2.10.1 release candidate to the finalized 2.10.1 version, adjusting version metadata, minimum required dependencies, documentation, and CI configuration.
- Bumped C header version string and minimum librdkafka requirement
- Updated Python project version, documentation, examples, and CI env var
- Revised CHANGELOG to document v2.10.1 as a maintenance release
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/confluent_kafka/src/confluent_kafka.h | Updated CFL_VERSION_STR, MIN_RD_KAFKA_VERSION, and error messages to 2.10.1 |
| pyproject.toml | Bumped version to 2.10.1 |
| examples/docker/Dockerfile.alpine | Set LIBRDKAFKA_VERSION to v2.10.1 |
| docs/conf.py | Updated Sphinx version to 2.10.1 |
| CHANGELOG.md | Changed v2.10.1 description to "maintenance release" and added librdkafka notes |
| .semaphore/semaphore.yml | Updated CI LIBRDKAFKA_VERSION env var to v2.10.1 |
|
|
||
| /** | ||
| * Minimum required librdkafka version. This is checked both during | ||
| * build-time (just below) and runtime (see confluent_kafka.c). | ||
| * Make sure to keep the MIN_RD_KAFKA_VERSION, MIN_VER_ERRSTR and #error | ||
| * defines and strings in sync. | ||
| */ | ||
| #define MIN_RD_KAFKA_VERSION 0x020a00ff | ||
| #define MIN_RD_KAFKA_VERSION 0x020a01ff |
There was a problem hiding this comment.
Using 0x020a01ff as the minimum librdkafka version may inadvertently reject actual 2.10.1 builds, which define RD_KAFKA_VERSION as 0x020a0100. Consider setting this to 0x020a0100 to match librdkafka v2.10.1.
| #define MIN_RD_KAFKA_VERSION 0x020a01ff | |
| #define MIN_RD_KAFKA_VERSION 0x020a0100 |
Copilot uses AI. Check for mistakes.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Yes 1.10.1rc1 is published and after installing it examples are working fine these are the prebuilt binaries |
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups