-
Notifications
You must be signed in to change notification settings - Fork 919
Preps for v1.5.2 release #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ve external meaning .. to docker-compose
…l dir .. rather than the installed module. Should once and for all eliminate the "ImportError: .. confluent_kafka.cimpl" problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit in tox.ini other than that LGTM
deps = | ||
{[base]deps} | ||
avro-python3 | ||
-rtests/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually required to be without space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
And restructured the source tree to avoid pytest/tox to load confluent-kafka from the source directory rather than what it has installed in its virtual environment.