Additional parameters are now allowed

tomchristie · tomchristie · commit 3e589ea458ea · 2016-01-13T13:39:49.000Z
diff --git a/coreapi/validation.py b/coreapi/validation.py
@@ -40,21 +40,6 @@ def validate_parameters(link, parameters):
     required = set([
         field.name for field in link.fields if field.required
     ])
-    optional = set([
-        field.name for field in link.fields if not field.required
-    ])
-
-    # Determine any parameter names supplied that are not valid.
-    unexpected = provided - (optional | required)
-    unexpected = ['"' + item + '"' for item in sorted(unexpected)]
-    if unexpected:
-        fmt = 'Unknown parameter{plural}: {listing}'
-        plural = 's' if len(unexpected) > 1 else ''
-        listing = ', '.join(unexpected)
-        raise ValueError(fmt.format(
-            plural=plural,
-            listing=listing
-        ))
 
     # Determine if any required field names not supplied.
     missing = required - provided
diff --git a/tests/test_validation.py b/tests/test_validation.py
@@ -26,9 +26,8 @@ def test_link_missing_required_parameter(link):
         validate_parameters(link, {'optional': 456})
 
 
-def test_link_with_invalid_parameter(link):
-    with pytest.raises(ValueError):
-        validate_parameters(link, {'required': 123, 'unknown': 123})
+def test_link_with_additional_parameter(link):
+    validate_parameters(link, {'required': 123, 'unknown': 123})
 
 
 # Test invalid parameter types.
