From 36f3e7e3cad46db39ec8209cce8072b667e1c1a3 Mon Sep 17 00:00:00 2001 From: hurturk Date: Fri, 9 Jun 2017 23:31:46 +0300 Subject: [PATCH] Prevent path/param drop when both fields have the same name. --- coreapi/transports/http.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/coreapi/transports/http.py b/coreapi/transports/http.py index a548024..50077d5 100644 --- a/coreapi/transports/http.py +++ b/coreapi/transports/http.py @@ -99,9 +99,14 @@ def _get_params(method, encoding, fields, params=None): if params is None: return empty_params + # Collect path related variables + path = { + field.name: utils.validate_path_param(params[field.name]) + for field in fields if field.location == 'path' + } + fields = [field for field in fields if field.location != 'path'] field_map = {field.name: field for field in fields} - path = {} query = {} data = {} files = {} @@ -113,6 +118,10 @@ def _get_params(method, encoding, fields, params=None): seen_body = False for key, value in params.items(): + # Skip the value if we have it in the path only + if key in path.keys() and key not in field_map: + continue + if key not in field_map or not field_map[key].location: # Default is 'query' for 'GET' and 'DELETE', and 'form' for others. location = 'query' if method in ('GET', 'DELETE') else 'form' @@ -124,9 +133,7 @@ def _get_params(method, encoding, fields, params=None): location = 'body' try: - if location == 'path': - path[key] = utils.validate_path_param(value) - elif location == 'query': + if location == 'query': query[key] = utils.validate_query_param(value) elif location == 'body': data = utils.validate_body_param(value, encoding=encoding) pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy