refactor(rtl.service): ensure RTL detection works regardless of HTML attribute or CSS property direction (computed style check)

xidedix · xidedix · commit 5d4082ed2d07 · 2025-07-03T16:08:37.000+02:00
diff --git a/projects/coreui-angular/src/lib/services/rtl.service.ts b/projects/coreui-angular/src/lib/services/rtl.service.ts
@@ -8,9 +8,12 @@ export class RtlService {
 
   isRTL(element?: HTMLElement | null): boolean {
     if (element) {
-      return element.closest('[dir="rtl"]') !== null;
+      return (
+        element.closest('[dir="rtl"]') !== null ||
+        this.#document.defaultView?.getComputedStyle(element).direction === 'rtl'
+      );
     }
 
-    return this.#document?.documentElement?.dir === 'rtl' || this.#document?.body?.dir === 'rtl';
+    return [this.#document?.documentElement?.dir, this.#document?.body?.dir].includes('rtl');
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,12 @@ export class RtlService {`
`8`	`8`
`9`	`9`	`isRTL(element?: HTMLElement \| null): boolean {`
`10`	`10`	`if (element) {`
`11`		`- return element.closest('[dir="rtl"]') !== null;`
	`11`	`+ return (`
	`12`	`+ element.closest('[dir="rtl"]') !== null \|\|`
	`13`	`+ this.#document.defaultView?.getComputedStyle(element).direction === 'rtl'`
	`14`	`+ );`
`12`	`15`	`}`
`13`	`16`
`14`		`- return this.#document?.documentElement?.dir === 'rtl' \|\| this.#document?.body?.dir === 'rtl';`
	`17`	`+ return [this.#document?.documentElement?.dir, this.#document?.body?.dir].includes('rtl');`
`15`	`18`	`}`
`16`	`19`	`}`