fix(readability/casting): noexcept *functions

aaronliu0130 · aaronliu0130 · commit 8431b77d2e94 · 2025-04-17T15:56:28.000-04:00
diff --git a/cpplint.py b/cpplint.py
@@ -6645,10 +6645,10 @@ def CheckCStyleCast(filename, clean_lines, linenum, cast_type, pattern, error):
     if context.endswith((" operator++", " operator--", "::operator++", "::operator--")):
         return False
 
-    # A single unnamed argument for a function tends to look like old style cast.
-    # If we see those, don't issue warnings for deprecated casts.
+    # A single unnamed argument for a function tend to look like old style cast;
+    # so do function pointers. If we see those, don't issue warnings for deprecated casts.
     remainder = line[match.end(0) :]
-    if re.match(r"^\s*(?:;|const\b|throw\b|final\b|override\b|[=>{),]|->)", remainder):
+    if re.match(r"^\s*(?:;|(?:const|throw|final|override|noexcept)\b|[=>{),]|->)", remainder):
         return False
 
     # At this point, all that should be left is actual casts.
diff --git a/cpplint_unittest.py b/cpplint_unittest.py
@@ -1066,6 +1066,7 @@ def testDeprecatedCast(self):
         self.TestLint("void Function(bool(FunctionPointerArg)()) {}", "")
         self.TestLint("typedef set<int64_t, bool(*)(int64_t, int64_t)> SortedIdSet", "")
         self.TestLint("bool TraverseNode(T *Node, bool(VisitorBase:: *traverse) (T *t)) {}", "")
+        self.TestLint("void (*execute_)(operation_base*) noexcept(may_throw());", "")
 
     # The second parameter to a gMock method definition is a function signature
     # that often looks like a bad cast but should not picked up by lint.
