fix(eslint-plugin): [consistent-generic-constructors] resolve conflict with isolatedDeclarations if enabled in constructor option (typescript-eslint#11351)

nayounsang · web-flow · commit 0e884c7cbd08 · 2025-07-16T10:05:10.000-04:00
* test: add tc

* fix: ignore constructor report when id is enabled
diff --git a/packages/eslint-plugin/src/rules/consistent-generic-constructors.ts b/packages/eslint-plugin/src/rules/consistent-generic-constructors.ts
@@ -123,7 +123,8 @@ export default createRule<Options, MessageIds>({
           return;
         }
 
-        if (lhs?.typeArguments && !rhs.typeArguments) {
+        const isolatedDeclarations = context.parserOptions.isolatedDeclarations;
+        if (!isolatedDeclarations && lhs?.typeArguments && !rhs.typeArguments) {
           const hasParens =
             context.sourceCode.getTokenAfter(rhs.callee)?.value === '(';
           const extraComments = new Set(
diff --git a/packages/eslint-plugin/tests/rules/consistent-generic-constructors.test.ts b/packages/eslint-plugin/tests/rules/consistent-generic-constructors.test.ts
@@ -45,6 +45,16 @@ class A {
     `
 const a = function (a: Foo = new Foo<string>()) {};
     `,
+    {
+      code: `
+const foo: Foo<string> = new Foo();
+      `,
+      languageOptions: {
+        parserOptions: {
+          isolatedDeclarations: true,
+        },
+      },
+    },
     // type-annotation
     {
       code: 'const a = new Foo();',

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ export default createRule<Options, MessageIds>({`
`123`	`123`	`return;`
`124`	`124`	`}`
`125`	`125`
`126`		`- if (lhs?.typeArguments && !rhs.typeArguments) {`
	`126`	`+ const isolatedDeclarations = context.parserOptions.isolatedDeclarations;`
	`127`	`+ if (!isolatedDeclarations && lhs?.typeArguments && !rhs.typeArguments) {`
`127`	`128`	`const hasParens =`
`128`	`129`	`context.sourceCode.getTokenAfter(rhs.callee)?.value === '(';`
`129`	`130`	`const extraComments = new Set(`