update 129

fishercoder1534 · fishercoder1534 · commit dff045601517 · 2024-06-07T11:07:51.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_129.java b/src/main/java/com/fishercoder/solutions/_129.java
@@ -13,11 +13,7 @@ public int sumNumbers(TreeNode root) {
             }
             List<Integer> allNumbers = new ArrayList();
             dfs(root, new StringBuilder(), allNumbers);
-            int sum = 0;
-            for (int i : allNumbers) {
-                sum += i;
-            }
-            return sum;
+            return allNumbers.stream().mapToInt(i -> i).sum();
         }
 
         private void dfs(TreeNode root, StringBuilder sb, List<Integer> allNumbers) {
@@ -31,6 +27,8 @@ private void dfs(TreeNode root, StringBuilder sb, List<Integer> allNumbers) {
             if (root.left == null && root.right == null) {
                 allNumbers.add(Integer.parseInt(sb.toString()));
             }
+            //this is to delete the last value. since it's guaranteed that the value is between [0,9], so only one char needs to be deleted.
+            //however if the value is >= 10 then this approach needs to be adjusted
             sb.deleteCharAt(sb.length() - 1);
         }
     }
@@ -47,7 +45,9 @@ private int dfs(TreeNode root, int sum) {
             if (root.left == null && root.right == null) {
                 return sum * 10 + root.val;
             }
-            return dfs(root.left, sum * 10 + root.val) + dfs(root.right, sum * 10 + root.val);
+            int left = dfs(root.left, sum * 10 + root.val);
+            int right = dfs(root.right, sum * 10 + root.val);
+            return left + right;
         }
     }
 
diff --git a/src/test/java/com/fishercoder/_129Test.java b/src/test/java/com/fishercoder/_129Test.java
@@ -0,0 +1,30 @@
+package com.fishercoder;
+
+import com.fishercoder.common.classes.TreeNode;
+import com.fishercoder.common.utils.TreeUtils;
+import com.fishercoder.solutions._129;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Arrays;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class _129Test {
+    private static _129.Solution1 solution1;
+    private static _129.Solution2 solution2;
+
+    @BeforeEach
+    public void setup() {
+        solution1 = new _129.Solution1();
+        solution2 = new _129.Solution2();
+    }
+
+    @Test
+    public void test1() {
+        TreeNode root = TreeUtils.constructBinaryTree(Arrays.asList(1, 2, 3));
+        assertEquals(25, (solution1.sumNumbers(root)));
+        assertEquals(25, (solution2.sumNumbers(root)));
+    }
+
+}

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,7 @@ public int sumNumbers(TreeNode root) {`
`13`	`13`	`}`
`14`	`14`	`List<Integer> allNumbers = new ArrayList();`
`15`	`15`	`dfs(root, new StringBuilder(), allNumbers);`
`16`		`- int sum = 0;`
`17`		`- for (int i : allNumbers) {`
`18`		`- sum += i;`
`19`		`- }`
`20`		`- return sum;`
	`16`	`+ return allNumbers.stream().mapToInt(i -> i).sum();`
`21`	`17`	`}`
`22`	`18`
`23`	`19`	`private void dfs(TreeNode root, StringBuilder sb, List<Integer> allNumbers) {`
`@@ -31,6 +27,8 @@ private void dfs(TreeNode root, StringBuilder sb, List<Integer> allNumbers) {`
`31`	`27`	`if (root.left == null && root.right == null) {`
`32`	`28`	`allNumbers.add(Integer.parseInt(sb.toString()));`
`33`	`29`	`}`
	`30`	`+ //this is to delete the last value. since it's guaranteed that the value is between [0,9], so only one char needs to be deleted.`
	`31`	`+ //however if the value is >= 10 then this approach needs to be adjusted`
`34`	`32`	`sb.deleteCharAt(sb.length() - 1);`
`35`	`33`	`}`
`36`	`34`	`}`
`@@ -47,7 +45,9 @@ private int dfs(TreeNode root, int sum) {`
`47`	`45`	`if (root.left == null && root.right == null) {`
`48`	`46`	`return sum * 10 + root.val;`
`49`	`47`	`}`
`50`		`- return dfs(root.left, sum * 10 + root.val) + dfs(root.right, sum * 10 + root.val);`
	`48`	`+ int left = dfs(root.left, sum * 10 + root.val);`
	`49`	`+ int right = dfs(root.right, sum * 10 + root.val);`
	`50`	`+ return left + right;`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`