Skip to content

combine_first: conditional type-cast to rhs's dtype #10931

@crusaderky

Description

@crusaderky

test_combine_first is flaky. This is because the test randomly generates the test data, and if a chunk ends up being full of NaNs it will improperly trigger a FutureWarning in pandas that should only trigger when the whole Series is full of NaNs.

Reproducer linked below.

Additionally, if lhs is of dtype='datetime64[s]' and full of NaTs, while rhs has dtype='datetime64[ns]', the output dtype is rhs's dtype in pandas, but lhs's dtype in dask. This can't be fixed due to the dtype being eager in dask.

Metadata

Metadata

Assignees

No one assigned

    Labels

    dataframeneeds attentionIt's been a while since this was pushed on. Needs attention from the owner or a maintainer.p3Affects a small number of users or is largely cosmetic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy