(temp) switch to pyright

lucascolley · lucascolley · commit bcae393b0b4e · 2024-11-27T21:53:10.000Z
diff --git a/pixi.lock b/pixi.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -78,14 +78,16 @@ numpy = "*"
 pytest = "*"
 
 [tool.pixi.feature.lint.pypi-dependencies]
-basedpyright = "*"
+# basedpyright = "*"
+pyright = "*"
 
 [tool.pixi.feature.lint.tasks]
 pre-commit-install = { cmd = "pre-commit install" }
 pre-commit = { cmd = "pre-commit run -v --all-files --show-diff-on-failure" }
 mypy = { cmd = "mypy", cwd = "." }
 pylint = { cmd = ["pylint", "array_api_extra"], cwd = "src" }
-pyright = { cmd = "basedpyright", cwd = "." }
+# pyright = { cmd = "basedpyright", cwd = "." }
+pyright = { cmd = "pyright", cwd = "." }
 lint = { depends-on = ["pre-commit", "pylint", "mypy", "pyright"] }
 
 [tool.pixi.feature.tests.dependencies]
@@ -180,17 +182,25 @@ disallow_incomplete_defs = true
 
 # pyright
 
-[tool.basedpyright]
+# [tool.basedpyright]
+# include = ["src", "tests"]
+# pythonVersion = "3.10"
+# pythonPlatform = "All"
+# typeCheckingMode = "all"
+
+# # data-apis/array-api#589
+# reportAny = false
+# reportExplicitAny = false
+# # data-apis/array-api-strict#6
+# reportUnknownMemberType = false
+
+[tool.pyright]
 include = ["src", "tests"]
 pythonVersion = "3.10"
 pythonPlatform = "All"
-typeCheckingMode = "all"
-
-# data-apis/array-api#589
-reportAny = false
-reportExplicitAny = false
-# data-apis/array-api-strict#6
+typeCheckingMode = "strict"
 reportUnknownMemberType = false
+reportImportCycles = true
 
 
 # Ruff
diff --git a/src/array_api_extra/_compat.py b/src/array_api_extra/_compat.py
@@ -6,6 +6,8 @@
 import sys
 import typing
 
+from typing_extensions import override
+
 if typing.TYPE_CHECKING:
     from ._typing import Array, Device
 
@@ -16,6 +18,7 @@
 # when the array backend is not the CPU.
 # (since it is not easy to tell which device a dask array is on)
 class _dask_device:  # pylint: disable=invalid-name
+    @override
     def __repr__(self) -> str:
         return "DASK_DEVICE"
 
@@ -118,7 +121,7 @@ def _is_dask_array(x: Array) -> bool:
         return False
 
     # pylint: disable=import-error, import-outside-toplevel
-    import dask.array  # type: ignore[import-not-found]
+    import dask.array  # type: ignore[import-not-found]  # pyright: ignore[reportMissingImports]
 
     return isinstance(x, dask.array.Array)
 
@@ -133,10 +136,10 @@ def _is_jax_zero_gradient_array(x: Array) -> bool:
         return False
 
     # pylint: disable=import-error, import-outside-toplevel
-    import jax  # type: ignore[import-not-found]
+    import jax  # type: ignore[import-not-found]  # pyright: ignore[reportMissingImports]
     import numpy as np  # pylint: disable=import-outside-toplevel
 
-    return isinstance(x, np.ndarray) and x.dtype == jax.float0
+    return isinstance(x, np.ndarray) and x.dtype == jax.float0  # pyright: ignore[reportUnknownVariableType]
 
 
 def _is_jax_array(x: Array) -> bool:
@@ -146,7 +149,7 @@ def _is_jax_array(x: Array) -> bool:
         return False
 
     # pylint: disable=import-error, import-outside-toplevel
-    import jax
+    import jax  # pyright: ignore[reportMissingImports]
 
     return isinstance(x, jax.Array) or _is_jax_zero_gradient_array(x)
 
@@ -159,7 +162,7 @@ def _is_pydata_sparse_array(x: Array) -> bool:
         return False
 
     # pylint: disable=import-error, import-outside-toplevel
-    import sparse  # type: ignore[import-not-found]
+    import sparse  # type: ignore[import-not-found]  # pyright: ignore[reportMissingImports]
 
     # TODO: Account for other backends.
     return isinstance(x, sparse.SparseArray)
diff --git a/src/array_api_extra/_typing.py b/src/array_api_extra/_typing.py
@@ -5,6 +5,6 @@
 
 # To be changed to a Protocol later (see data-apis/array-api#589)
 Array = Any  # type: ignore[no-any-explicit]
-Device = Any
+Device = Any  # type: ignore[no-any-explicit]
 
 __all__ = ["Array", "Device", "ModuleType"]
diff --git a/src/array_api_extra/_utils.py b/src/array_api_extra/_utils.py
@@ -58,6 +58,7 @@ def in1d(
 
     if assume_unique:
         return ret[: x1.shape[0]]
+    # https://github.com/KotlinIsland/basedmypy/issues/826
     # https://github.com/pylint-dev/pylint/issues/10095
     # pylint: disable=possibly-used-before-assignment
-    return xp.take(ret, rev_idx, axis=0)
+    return xp.take(ret, rev_idx, axis=0)  # type: ignore[possibly-undefined]  # pyright: ignore[reportPossiblyUnboundVariable]
