test: fix CI and unfinalize HasArrayNamespace (#29)

nstarman · jorenham · web-flow · commit 204c20aa2aae · 2025-06-18T15:59:02.000+02:00
Co-authored-by: Joren Hammudoglu &lt;jhammudoglu@gmail.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -57,7 +57,6 @@ jobs:
         run: >-
           uv run --frozen pytest
           --cov --cov-report=xml --cov-report=term --durations=20
-          src docs tests 
 
       - name: Upload coverage report
         uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24
@@ -82,15 +81,14 @@ jobs:
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install the project
-        run: uv sync --locked --group test --resolution lowest-direct
+        run: uv sync --group test --resolution lowest-direct
 
       - name: Test package
         run: >-
           uv run --frozen pytest
           --cov --cov-report=xml --cov-report=term --durations=20
-          src docs tests
 
       - name: Upload coverage report
-        uses: codecov/codecov-action@v18283e04ce6e62d37312384ff67231eb8fd56d24
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.gitignore b/.gitignore
@@ -25,3 +25,6 @@ venv/
 
 # Mac files
 .DS_Store
+
+# Coverage
+.coverage
diff --git a/pyproject.toml b/pyproject.toml
@@ -46,8 +46,8 @@
   ]
   test = [
     "numpy>=1.25",
-    "pytest>=8.3.3",
-    "pytest-cov>=3",
+    "pytest==8.3.3",
+    "pytest-cov>=6",
     "pytest-github-actions-annotate-failures>=0.3.0",
     "sybil>=8.0.0",
   ]
@@ -115,7 +115,7 @@ version_tuple = {version_tuple!r}
   ]
   log_cli_level = "INFO"
   minversion = "8.3"
-  testpaths = ["README.md", "src/", "docs", "tests/"]
+  testpaths = ["README.md", "src/", "tests/"]
   norecursedirs = ["docs/_build"]
   xfail_strict = true
 
diff --git a/src/array_api_typing/_namespace.py b/src/array_api_typing/_namespace.py
@@ -1,14 +1,13 @@
 __all__ = ("HasArrayNamespace",)
 
 from types import ModuleType
-from typing import Protocol, final
+from typing import Protocol
 from typing_extensions import TypeVar
 
-T = TypeVar("T", bound=object, default=ModuleType)  # PEP 696 default
+T_co = TypeVar("T_co", covariant=True, bound=object, default=ModuleType)
 
 
-@final
-class HasArrayNamespace(Protocol[T]):  # type: ignore[misc]  # see python/mypy#17288
+class HasArrayNamespace(Protocol[T_co]):
     """Protocol for classes that have an `__array_namespace__` method.
 
     Example:
@@ -26,4 +25,4 @@ class HasArrayNamespace(Protocol[T]):  # type: ignore[misc]  # see python/mypy#1
 
     """
 
-    def __array_namespace__(self, /, *, api_version: str | None = None) -> T: ...  # noqa: PLW3201
+    def __array_namespace__(self, /, *, api_version: str | None = None) -> T_co: ...  # noqa: PLW3201
diff --git a/tests/__init__.py b/tests/__init__.py
diff --git a/tests/test_namespace.py b/tests/test_namespace.py
@@ -5,8 +5,11 @@
 
 
 @runtime_checkable
-class CheckableHasArrayNamespace(xpt.HasArrayNamespace, Protocol):  # type: ignore[misc]
-    """Runtime checkable version of HasArrayNamespace."""
+class CheckableHasArrayNamespace(xpt.HasArrayNamespace, Protocol):
+    """A runtime-checkable version of the HasArrayNamespace protocol."""
+
+    # This class is used to ensure that the protocol can be checked at runtime.
+    # It inherits from xpt.HasArrayNamespace and is marked as runtime_checkable.
 
 
 class GoodArray:
diff --git a/uv.lock b/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,8 @@`
`46`	`46`	`]`
`47`	`47`	`test = [`
`48`	`48`	`"numpy>=1.25",`
`49`		`- "pytest>=8.3.3",`
`50`		`- "pytest-cov>=3",`
	`49`	`+ "pytest==8.3.3",`
	`50`	`+ "pytest-cov>=6",`
`51`	`51`	`"pytest-github-actions-annotate-failures>=0.3.0",`
`52`	`52`	`"sybil>=8.0.0",`
`53`	`53`	`]`
`@@ -115,7 +115,7 @@ version_tuple = {version_tuple!r}`
`115`	`115`	`]`
`116`	`116`	`log_cli_level = "INFO"`
`117`	`117`	`minversion = "8.3"`
`118`		`- testpaths = ["README.md", "src/", "docs", "tests/"]`
	`118`	`+ testpaths = ["README.md", "src/", "tests/"]`
`119`	`119`	`norecursedirs = ["docs/_build"]`
`120`	`120`	`xfail_strict = true`
`121`	`121`