Switch to a WeakMap to avoid memory leak

developit · web-flow · commit 3c7521cd43d2 · 2019-12-03T22:48:50.000-05:00
diff --git a/src/vhtml.js b/src/vhtml.js
@@ -9,7 +9,7 @@ let DOMAttributeNames = {
 	htmlFor: 'for'
 };
 
-let sanitized = {};
+let sanitized = new WeakMap();
 
 /** Hyperscript reviver that constructs a sanitized HTML string. */
 export default function h(name, attrs) {
@@ -47,14 +47,14 @@ export default function h(name, attrs) {
 					for (let i=child.length; i--; ) stack.push(child[i]);
 				}
 				else {
-					s += sanitized[child]===true ? child : esc(child);
+					s += sanitized.has(child) ? child : esc(child);
 				}
 			}
 		}
 
 		s += name ? `</${name}>` : '';
 	}
 
-	sanitized[s] = true;
+	sanitized.set(s, true);
 	return s;
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ let DOMAttributeNames = {`
`9`	`9`	`htmlFor: 'for'`
`10`	`10`	`};`
`11`	`11`
`12`		`-let sanitized = {};`
	`12`	`+let sanitized = new WeakMap();`
`13`	`13`
`14`	`14`	`/** Hyperscript reviver that constructs a sanitized HTML string. */`
`15`	`15`	`export default function h(name, attrs) {`
`@@ -47,14 +47,14 @@ export default function h(name, attrs) {`
`47`	`47`	`for (let i=child.length; i--; ) stack.push(child[i]);`
`48`	`48`	`}`
`49`	`49`	`else {`
`50`		`- s += sanitized[child]===true ? child : esc(child);`
	`50`	`+ s += sanitized.has(child) ? child : esc(child);`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	s += name ? `</${name}>` : '';
`56`	`56`	`}`
`57`	`57`
`58`		`- sanitized[s] = true;`
	`58`	`+ sanitized.set(s, true);`
`59`	`59`	`return s;`
`60`	`60`	`}`