changed some stuff for optimisation, fixed some errors, changed README

SubhrajitPrusty · SubhrajitPrusty · commit 467f1fb265f7 · 2017-10-22T12:01:24.000+05:30
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,3 @@
+ENV
+ghostdriver.log
+phantomjs.exe
diff --git a/README.md b/README.md
@@ -1,30 +1,28 @@
 # FbPostUsingPython
->It is a small script to post status on your FB wall using python..!
+>It is a small script to post status on your FB wall using python
 
-#Installation
-1- Install python 3.5 from [Python.org](https://www.python.org)
+# Installation
+* Install python 3 from [Python.org](https://www.python.org)
 
-2- `sudo apt-get install python3-pip` (For Ubuntu Users)
+* Install pip `$ sudo apt-get install python3-pip` (For Ubuntu Users)
 
-3- `python setup.py` or `python3 setup.py`
+* `$ python setup.py` or `$ python3 setup.py`
 
-  This will install all these packages
+* Download [PhantonJS](http://phantomjs.org/download.html) and copy the exe file into the same folder as your repository
 
-  * `pip install bs4`
+After the installation, open terminal at the root folder
 
-  * `pip install selenium`
+Run `python fb.py` or `python3 fb.py` to post status from terminal or cmd.
 
-After the installation, open terminal at the root folder--
+Note:- Use Mozilla Firefox V40.0+ to make this script work for you.
 
-Run `python fb.py` or `python3 fb.py` to post status from terminal or cmd.
 
-Note:- Use Mozilla Firefox V40.0 to make this script work for you.
 
-##Some Useful Installation Tips ( Ubuntu )
+## Some Useful Installation Tips ( Ubuntu )
 
-If you have already installed python 2.7 install python 3 as well but it may be the problem that the packages installed with respect to python 2.7 and shows error for the python 3 packages,
+If you have already installed python 2.7 install python3 as well but it may be the problem that the packages are installed with respect to python 2.7 and shows error for the python 3 packages,
 
-So you need to install virtual Environment for the python 3 to install python3 packages.
+So, you need to install a Virtual Environment for the python3 to install python3 packages.
 
 ```
     virtualenv -p /usr/bin/python3 py3env
@@ -34,7 +32,7 @@ So you need to install virtual Environment for the python 3 to install python3 p
 
 After setting virtual environment install packages listed above and Enjoy.
 
-#License
+# License
 
 Copyright (c) 2016 Ankit Jain - Released under the Apache License
 
diff --git a/fb.py b/fb.py
@@ -1,5 +1,5 @@
 import time
-import platform
+import os
 import getpass
 import selenium
 from selenium import webdriver
@@ -11,19 +11,19 @@
 def get_title(driver):
     html_page = driver.page_source
     soup = BeautifulSoup(html_page,'html.parser')
-    print(soup.title.string+"\n")
+    # print(soup.title.string+"\n")
     return soup.title.string
 
-if platform.system() == 'Windows':
-    pathr = 'C:\\Program Files\\phantomjs-2.1.1-windows\\bin\\phantomjs.exe'
+if os.name == 'nt':
+    pathr = 'phantomjs.exe'
 else:
     pathr = './phantomjs'
 driver = webdriver.PhantomJS(pathr, service_args=['--ignore-ssl-errors=true', '--ssl-protocol=any'])
 url = "https://mbasic.facebook.com/"
 
 while True:
     driver.get(url)
-    time.sleep(2)
+    # time.sleep(2)
     get_title(driver)
 
     eMail = input("Enter your Email Id or Mobile No. to Login\n")
@@ -36,7 +36,7 @@ def get_title(driver):
 
     login = driver.find_element_by_name("login")
     login.click()
-    time.sleep(5)
+    # time.sleep(5)
     
 
     if get_title(driver) != "Log in to Facebook | Facebook":
@@ -50,7 +50,7 @@ def get_title(driver):
         status.send_keys(pp)
         button = driver.find_element_by_name("view_post")
         button.click()
-        time.sleep(5)
+        # time.sleep(5)
         print("Your Status : '"+pp+"' has been uploaded!\n")
         driver.quit()
         break

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+ENV`
	`2`	`+ghostdriver.log`
	`3`	`+phantomjs.exe`