Merge pull request #3971 from Ten0/fix_missing_skip_insertion_attribute_in_unknown_attribute_error

weiznich · weiznich · commit 45915ac65483 · 2024-04-19T07:42:45.000+02:00
Fix missing attributes in "unknown attribute" error
diff --git a/diesel_compile_tests/tests/fail/derive/unknown_attribute.stderr b/diesel_compile_tests/tests/fail/derive/unknown_attribute.stderr
@@ -4,7 +4,7 @@ error: unknown attribute, expected one of `aggregate`, `not_sized`, `foreign_der
 5 | #[diesel(what = true)]
   |          ^^^^
 
-error: unknown attribute, expected one of `embed`, `column_name`, `sql_type`, `serialize_as`, `deserialize_as`, `select_expression`, `select_expression_type`
+error: unknown attribute, expected one of `embed`, `skip_insertion`, `column_name`, `sql_type`, `treat_none_as_default_value`, `treat_none_as_null`, `serialize_as`, `deserialize_as`, `select_expression`, `select_expression_type`
   --> tests/fail/derive/unknown_attribute.rs:12:14
    |
 12 |     #[diesel(what = true)]
diff --git a/diesel_derives/src/attrs.rs b/diesel_derives/src/attrs.rs
@@ -147,8 +147,11 @@ impl Parse for FieldAttr {
                 &name,
                 &[
                     "embed",
+                    "skip_insertion",
                     "column_name",
                     "sql_type",
+                    "treat_none_as_default_value",
+                    "treat_none_as_null",
                     "serialize_as",
                     "deserialize_as",
                     "select_expression",

Original file line number	Diff line number	Diff line change
@@ -4,7 +4,7 @@ error: unknown attribute, expected one of `aggregate`, `not_sized`, `foreign_der
`4`	`4`	`5 \| #[diesel(what = true)]`
`5`	`5`	`\| ^^^^`
`6`	`6`
`7`		-error: unknown attribute, expected one of `embed`, `column_name`, `sql_type`, `serialize_as`, `deserialize_as`, `select_expression`, `select_expression_type`
	`7`	+error: unknown attribute, expected one of `embed`, `skip_insertion`, `column_name`, `sql_type`, `treat_none_as_default_value`, `treat_none_as_null`, `serialize_as`, `deserialize_as`, `select_expression`, `select_expression_type`
`8`	`8`	`--> tests/fail/derive/unknown_attribute.rs:12:14`
`9`	`9`	`\|`
`10`	`10`	`12 \| #[diesel(what = true)]`