-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Comparing changes
Open a pull request
base repository: diesel-rs/diesel
base: v2.2.7
head repository: diesel-rs/diesel
compare: v2.2.8
- 19 commits
- 37 files changed
- 5 contributors
Commits on Feb 14, 2025
-
Improve CompatibleType diagnostic notes
I was told "OK I see this error message but my struct already implements Selectable so that's not useful". As it turns out, this message would sometimes be misunderstood as the `check_for_backend` part only relating to the `QueryableByName` usage, but not to the `Selectable` usage, whereas that is in fact the key point. Hopefully this new writing will avoid this. :)
Configuration menu - View commit details
-
Copy full SHA for 3c0f885 - Browse repository at this point
Copy the full SHA 3c0f885View commit details -
Co-authored-by: Georg Semmler <github@weiznich.de>
Configuration menu - View commit details
-
Copy full SHA for cd7f915 - Browse repository at this point
Copy the full SHA cd7f915View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3149b1 - Browse repository at this point
Copy the full SHA b3149b1View commit details -
Make
#[diesel(embed)]
fields be somewhat-checked by `#[check_for_ba……ckend]` Currently when a struct has `#[derive(Selectable)]`, `#[check_for_backend(...)]`, and `embed`s another `Selectable` struct that doesn't have `#[check_for_backend]` but whose `FromSqlRow` and `Selectable` impls don't match with regards to `CompatibleType`, the `#[check_for_backend]` does not point us to which of the embed fields is the culprit, because they are ignored. It seems that this can be avoided by generating the checks even for `embed` fields. The check for this was disabled in d6d9260 when the experimented-with approach was "always generating the check on Selectable" with the justification that it was consequently checked by the underlying field's own Selectable checks, before it was decided to instead have the `#[check_for_backend(...)]` attribute, so it seems that this justification was indeed legitimate at the time it was introduced, and doesn't hold anymore now.
Configuration menu - View commit details
-
Copy full SHA for fa9fc6a - Browse repository at this point
Copy the full SHA fa9fc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f88497d - Browse repository at this point
Copy the full SHA f88497dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e8914d - Browse repository at this point
Copy the full SHA 6e8914dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddd7860 - Browse repository at this point
Copy the full SHA ddd7860View commit details -
Make sqlite value function public
This commit turns the `read_*` functions of the `SqliteValue` type into public functions, which makes it easier for third party crates to access the underlying sqlite values in a performant way. This enables crates to not clone for example the string, but rather reuse the string slice we got from sqlite instead. This also turns all these functions into methods that require a mutable reference instead of a shared reference as technically each of those methods might mutate the underlying value according to the sqlite documentation.
Configuration menu - View commit details
-
Copy full SHA for f793413 - Browse repository at this point
Copy the full SHA f793413View commit details -
Fix an issue that disallowed using
copy_from
with more than 12 columnThis commit relaxes a trait constraint that restricted our copy from implementation for `Insertable` types to 12 columns. That happened because we used the `Default` impl for tuples from the rust standard library to construct the column types internally. The standard library only provides these impl for up to 12 tuple elements. The fix is to simply construct that type by calling `Default` for each of the column types seperatly and then constructing the tuple from that. I choose to not write a test for that as it doesn't change functionality in any meaningful way other than just allowing larger tuples.
Configuration menu - View commit details
-
Copy full SHA for 5aa29a7 - Browse repository at this point
Copy the full SHA 5aa29a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5291e99 - Browse repository at this point
Copy the full SHA 5291e99View commit details
Commits on Feb 15, 2025
-
Merge pull request #4076 from sgoll/asc-desc-whitespace
Remove trailing whitespace after ASC/DESC postfix operators
Configuration menu - View commit details
-
Copy full SHA for b322ce6 - Browse repository at this point
Copy the full SHA b322ce6View commit details -
Merge pull request #4116 from Ten0/distinct_on_space
Add space in "DISTINCT ON (...) "
Configuration menu - View commit details
-
Copy full SHA for 045e6ac - Browse repository at this point
Copy the full SHA 045e6acView commit details -
Merge pull request #4398 from sgoll/4397-delete-space
Remove unnecessary space from DELETE that causes duplication
Configuration menu - View commit details
-
Copy full SHA for 889dc35 - Browse repository at this point
Copy the full SHA 889dc35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c56ba2 - Browse repository at this point
Copy the full SHA 8c56ba2View commit details
Commits on Feb 17, 2025
-
Configuration menu - View commit details
-
Copy full SHA for f3cdbaf - Browse repository at this point
Copy the full SHA f3cdbafView commit details
Commits on Mar 3, 2025
-
Configuration menu - View commit details
-
Copy full SHA for cf340b8 - Browse repository at this point
Copy the full SHA cf340b8View commit details -
This commit updates our locally used rust version to 1.85. This time there were no new clippy lints It also updates the compile test output to match the new compiler output. (cherry picked from commit 8bd9c98) Conflicts: rust-toolchain
Configuration menu - View commit details
-
Copy full SHA for 25686d5 - Browse repository at this point
Copy the full SHA 25686d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c740fa4 - Browse repository at this point
Copy the full SHA c740fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2464571 - Browse repository at this point
Copy the full SHA 2464571View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.2.7...v2.2.8