Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: diesel-rs/diesel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.7
Choose a base ref
...
head repository: diesel-rs/diesel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.8
Choose a head ref
  • 19 commits
  • 37 files changed
  • 5 contributors

Commits on Feb 14, 2025

  1. Improve CompatibleType diagnostic notes

    I was told "OK I see this error message but my struct already implements Selectable so that's not useful".
    
    As it turns out, this message would sometimes be misunderstood as the `check_for_backend` part only relating to the `QueryableByName` usage, but not to the `Selectable` usage, whereas that is in fact the key point.
    
    Hopefully this new writing will avoid this. :)
    Ten0 authored and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    3c0f885 View commit details
    Browse the repository at this point in the history
  2. Add missing backquotes

    Co-authored-by: Georg Semmler <github@weiznich.de>
    Ten0 and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    cd7f915 View commit details
    Browse the repository at this point in the history
  3. bump compile tests

    Ten0 authored and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    b3149b1 View commit details
    Browse the repository at this point in the history
  4. Make #[diesel(embed)] fields be somewhat-checked by `#[check_for_ba…

    …ckend]`
    
    Currently when a struct has `#[derive(Selectable)]`, `#[check_for_backend(...)]`, and `embed`s another `Selectable` struct that doesn't have `#[check_for_backend]` but whose `FromSqlRow` and `Selectable` impls don't match with regards to `CompatibleType`, the `#[check_for_backend]` does not point us to which of the embed fields is the culprit, because they are ignored.
    
    It seems that this can be avoided by generating the checks even for `embed` fields.
    
    The check for this was disabled in d6d9260 when the experimented-with approach was "always generating the check on Selectable" with the justification that it was consequently checked by the underlying field's own Selectable checks, before it was decided to instead have the `#[check_for_backend(...)]` attribute, so it seems that this justification was indeed legitimate at the time it was introduced, and doesn't hold anymore now.
    Ten0 authored and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    fa9fc6a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f88497d View commit details
    Browse the repository at this point in the history
  6. Fix the compilation error (previously bug)

    Ten0 authored and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    6e8914d View commit details
    Browse the repository at this point in the history
  7. Add compile error test

    Ten0 authored and weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    ddd7860 View commit details
    Browse the repository at this point in the history
  8. Make sqlite value function public

    This commit turns the `read_*` functions of the `SqliteValue` type into
    public functions, which makes it easier for third party crates to access
    the underlying sqlite values in a performant way. This enables crates to
    not clone for example the string, but rather reuse the string slice we got
    from sqlite instead.
    
    This also turns all these functions into methods that require a mutable
    reference instead of a shared reference as technically each of those
    methods might mutate the underlying value according to the sqlite
    documentation.
    weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    f793413 View commit details
    Browse the repository at this point in the history
  9. Fix an issue that disallowed using copy_from with more than 12 column

    This commit relaxes a trait constraint that restricted our copy from
    implementation for `Insertable` types to 12 columns. That happened
    because we used the `Default` impl for tuples from the rust standard
    library to construct the column types internally. The standard library
    only provides these impl for up to 12 tuple elements. 
    
    The fix is to simply construct that type by calling `Default` for each
    of the column types seperatly and then constructing the tuple from that.
    
    I choose to not write a test for that as it doesn't change functionality
    in any meaningful way other than just allowing larger tuples.
    weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    5aa29a7 View commit details
    Browse the repository at this point in the history
  10. Prepare a 2.2.8 release

    This commit prepares a 2.2.8 release that includes the following
    changes:
    
    * #4472
    * #4484
    * #4486
    * #4480
    weiznich committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    5291e99 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2025

  1. Merge pull request #4076 from sgoll/asc-desc-whitespace

    Remove trailing whitespace after ASC/DESC postfix operators
    weiznich authored and sgoll committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    b322ce6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4116 from Ten0/distinct_on_space

    Add space in "DISTINCT ON (...) "
    pksunkara authored and sgoll committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    045e6ac View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4398 from sgoll/4397-delete-space

    Remove unnecessary space from DELETE that causes duplication
    weiznich authored and sgoll committed Feb 15, 2025
    Configuration menu
    Copy the full SHA
    889dc35 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8c56ba2 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2025

  1. Configuration menu
    Copy the full SHA
    f3cdbaf View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2025

  1. Configuration menu
    Copy the full SHA
    cf340b8 View commit details
    Browse the repository at this point in the history
  2. Bump to 1.85

    This commit updates our locally used rust version to 1.85. This time
    there were no new clippy lints
    
    It also updates the compile test output to match the new compiler
    output.
    
    (cherry picked from commit 8bd9c98)
    
    Conflicts:
    	rust-toolchain
    weiznich authored and Ten0 committed Mar 3, 2025
    Configuration menu
    Copy the full SHA
    25686d5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c740fa4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2464571 View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy