2: add virtualenv #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # install "pip", since the vast majority of users of this image will want it | ||
| RUN curl -SL 'https://bootstrap.pypa.io/get-pip.py' | python2 | ||
| # install "pip" and "virtualenv", since the vast majority of users of this image will want it | ||
| RUN curl -SL 'https://bootstrap.pypa.io/get-pip.py' | python2 && pip install virtualenv |
There was a problem hiding this comment.
Why not do virtualenv in a separate RUN line, and thus have something that's easy to copy/paste into 3/Dockerfile too? 😄
There was a problem hiding this comment.
Ahh, nevermind, just noticed your comment on the description about pyvenv - but the separate RUN line question still applies. Do we gain anything from this being together like this?
There was a problem hiding this comment.
not really, I will move it to a separate RUN line if you prefer.
There was a problem hiding this comment.
Yeah, I think it would improve future readability. :)
|
PTAL Tested: |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
:3 already has
pyvenv