fix: support type expression for @this tag (fixes eslint#181) (eslint#182)

fredj · tmcw · commit 07f4751cf650 · 2018-04-11T10:17:37.000-07:00
diff --git a/lib/doctrine.js b/lib/doctrine.js
@@ -607,13 +607,13 @@
             return true;
         };
 
-        TagParser.prototype.parseThis = function parseAccess() {
-            // this name may be a name expression (e.g. {foo.bar})
-            // or a name path (e.g. foo.bar)
+        TagParser.prototype.parseThis = function parseThis() {
+            // this name may be a name expression (e.g. {foo.bar}),
+            // an union (e.g. {foo.bar|foo.baz}) or a name path (e.g. foo.bar)
             var value = trim(sliceSource(source, index, this._last));
             if (value && value.charAt(0) === '{') {
                 var gotType = this.parseType();
-                if (gotType && this._tag.type.type === 'NameExpression') {
+                if (gotType && this._tag.type.type === 'NameExpression' || this._tag.type.type === 'UnionType') {
                     this._tag.name = this._tag.type.name;
                     return true;
                 } else {
diff --git a/test/parse.js b/test/parse.js
@@ -1207,9 +1207,25 @@ describe('parse', function () {
             ].join('\n'), { unwrap: true });
         res.tags.should.have.length(1);
         res.tags[0].should.have.property('title', 'this');
+        res.tags[0].type.should.have.property('type', 'NameExpression');
         res.tags[0].should.have.property('name', 'thingName.name');
     });
 
+    it('this with UnionType expression', function () {
+        var res = doctrine.parse(
+            [
+              "/**",
+              " * @this {thingName.name|FooBar}",
+              "*/"
+            ].join('\n'), { unwrap: true });
+        res.tags.should.have.length(1);
+        res.tags[0].should.have.property('title', 'this');
+        res.tags[0].type.should.have.property('type', 'UnionType');
+        res.tags[0].type.elements.should.have.length(2);
+        res.tags[0].type.elements.should.containEql({type: 'NameExpression', name: 'thingName.name'});
+        res.tags[0].type.elements.should.containEql({type: 'NameExpression', name: 'FooBar'});
+    });
+
     it('this error with type application', function () {
         var res = doctrine.parse(
             [
