Merge inferred return type like we do for params. Refs #359 (#604)

tmcw · web-flow · commit 29cd58bb3165 · 2016-11-18T11:59:15.000-05:00
diff --git a/lib/infer/return.js b/lib/infer/return.js
@@ -14,7 +14,9 @@ var findTarget = require('./finders').findTarget,
  */
 module.exports = function () {
   return shouldSkipInference(function inferReturn(comment) {
-    if (comment.returns) {
+    if (Array.isArray(comment.returns) &&
+      comment.returns.length &&
+      comment.returns[0].type) {
       return comment;
     }
     var path = findTarget(comment.context.ast);
@@ -29,9 +31,14 @@ module.exports = function () {
     if (t.isFunction(fn) &&
       fn.returnType &&
       fn.returnType.typeAnnotation) {
-      comment.returns = [{
-        type: flowDoctrine(fn.returnType.typeAnnotation)
-      }];
+      var returnType = flowDoctrine(fn.returnType.typeAnnotation);
+      if (comment.returns) {
+        comment.returns[0].type = returnType;
+      } else {
+        comment.returns = [{
+          type: returnType
+        }];
+      }
     }
     return comment;
   });
diff --git a/test/fixture/merge-infered-type.input.js b/test/fixture/merge-infered-type.input.js
@@ -2,7 +2,7 @@
  * Add five to `x`.
  *
  * @param x The number to add five to.
- * @returns {number} x plus five.
+ * @returns x plus five.
  */
 function addFive(x: number): number {
   return x + 5;
diff --git a/test/fixture/merge-infered-type.output.json b/test/fixture/merge-infered-type.output.json
@@ -98,10 +98,7 @@
         "title": "returns",
         "description": "x plus five.",
         "lineNumber": 4,
-        "type": {
-          "type": "NameExpression",
-          "name": "number"
-        }
+        "type": null
       }
     ],
     "loc": {

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	* Add five to `x`.
`3`	`3`	`*`
`4`	`4`	`* @param x The number to add five to.`
`5`		`- * @returns {number} x plus five.`
	`5`	`+ * @returns x plus five.`
`6`	`6`	`*/`
`7`	`7`	`function addFive(x: number): number {`
`8`	`8`	`return x + 5;`