test(coverage): Improve test coverage of document exported

tmcw · tmcw · commit 5bfc660a98a2 · 2016-12-28T22:25:45.000-05:00
diff --git a/bin/documentation.js b/bin/documentation.js
@@ -12,6 +12,9 @@ var argv = yargs
   .command(commands.build)
   .command(commands.lint)
   .command(commands.readme)
+  .fail(function (msg, error) {
+    throw error;
+  })
   .version(function () {
     return require('../package').version;
   })
diff --git a/lib/commands/build.js b/lib/commands/build.js
@@ -49,17 +49,15 @@ module.exports.builder = extend({},
  * just a thin wrapper around this one.
  */
 module.exports.handler = function build(argv, callback) {
+  console.log(argv);
   argv._handled = true;
   argv = sharedOptions.expandInputs(argv);
   if (argv.f === 'html' && argv.o === 'stdout') {
     throw new Error('The HTML output mode requires a destination directory set with -o');
   }
 
   var generator = documentation.build
-    .bind(null, argv.input, argv, onDocumented);
-
-  function onDocumented(err, comments) {
-    if (err) {
+    .bind(null, argv.input, argv, onDocumented); function onDocumented(err, comments) { if (err) {
       if (typeof callback === 'function') {
         return callback(err);
       }
diff --git a/lib/extractors/exported.js b/lib/extractors/exported.js
@@ -103,6 +103,9 @@ function walkExported(ast, data, addComment) {
             throw new Error('Unreachable');
           }
 
+          if (bindingPath === undefined) {
+            throw new Error(`Unable to find the value ${exported} in ${specData.file}`);
+          }
           traverseExportedSubtree(bindingPath, specData, addComments, exported);
         });
         return path.skip();
@@ -242,7 +245,10 @@ function findExportDeclaration(dataCache, name, exportKind, referrer, filename)
     }
   });
 
-  return {ast: rv, data: data};
+  return {
+    ast: rv,
+    data: data
+  };
 }
 
 // Since we cannot use scope.getBinding for types this walks the current scope looking for a
diff --git a/test/fixture/document-exported-bad/exports-z.js b/test/fixture/document-exported-bad/exports-z.js
@@ -0,0 +1 @@
+export var z = 1;
diff --git a/test/fixture/document-exported-bad/x.js b/test/fixture/document-exported-bad/x.js
@@ -0,0 +1 @@
+export {y as x} from './exports-z.js';
diff --git a/test/test.js b/test/test.js
@@ -59,6 +59,14 @@ if (fs.existsSync(path.join(__dirname, '../.git'))) {
   });
 }
 
+test('document-exported error', function (t) {
+  var file = path.join(__dirname, 'fixture', 'document-exported-bad', 'x.js');
+  documentation.build([file], { documentExported: true }, function (err, result) {
+    t.match(err.message, /Unable to find the value x/g, 'Produces a descriptive error');
+    t.end();
+  });
+});
+
 test('external modules option', function (t) {
   documentation.build([
     path.join(__dirname, 'fixture', 'external.input.js')

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,9 @@ function walkExported(ast, data, addComment) {`
`103`	`103`	`throw new Error('Unreachable');`
`104`	`104`	`}`
`105`	`105`
	`106`	`+ if (bindingPath === undefined) {`
	`107`	+ throw new Error(`Unable to find the value ${exported} in ${specData.file}`);
	`108`	`+ }`
`106`	`109`	`traverseExportedSubtree(bindingPath, specData, addComments, exported);`
`107`	`110`	`});`
`108`	`111`	`return path.skip();`
`@@ -242,7 +245,10 @@ function findExportDeclaration(dataCache, name, exportKind, referrer, filename)`
`242`	`245`	`}`
`243`	`246`	`});`
`244`	`247`
`245`		`- return {ast: rv, data: data};`
	`248`	`+ return {`
	`249`	`+ ast: rv,`
	`250`	`+ data: data`
	`251`	`+ };`
`246`	`252`	`}`
`247`	`253`
`248`	`254`	`// Since we cannot use scope.getBinding for types this walks the current scope looking for a`