Skip to content

Commit ce330d0

Browse files
Compiler: Rework DefaultTagHelperDescriptorFactory and RequiredAttributeParser (#11977)
I recommend reviewing this commit-by-commit. In particular, the first commit (2bea412) is a big one that could potentially be skipped. The key changes are in `RequiredAttributeParser` and `DefaultTagHelperDescriptorFactory` to reduce allocations and clean up old logic. ---- CI Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2736616&view=results Test Insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/646136 Toolset Run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2736618&view=results
2 parents 27d4d4c + 826e86a commit ce330d0

File tree

11 files changed

+1598
-2078
lines changed

11 files changed

+1598
-2078
lines changed

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/CSharp/DefaultTagHelperDescriptorFactory.cs

Lines changed: 151 additions & 151 deletions
Large diffs are not rendered by default.

src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/CSharp/DefaultTagHelperDescriptorProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public override void Execute(TagHelperDescriptorProviderContext context)
2424
}
2525

2626
var targetSymbol = context.TargetSymbol;
27-
var factory = new DefaultTagHelperDescriptorFactory(compilation, context.IncludeDocumentation, context.ExcludeHidden);
27+
var factory = new DefaultTagHelperDescriptorFactory(context.IncludeDocumentation, context.ExcludeHidden);
2828
var collector = new Collector(compilation, targetSymbol, factory, tagHelperTypeSymbol);
2929
collector.Collect(context);
3030
}

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy