Default excludes #49454
Open
Default excludes #49454
+677
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @@tmat. |
This was referenced Jun 20, 2025
Implement watching project, props and targets files.
|
@DustinCampbell ptal |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the FileWatcher in dotnet-watch to support per-file watching and SDK DefaultItemExcludes globs, while continuing to ignore bin/obj by default. It also adds re-evaluation support for project file changes and refactors watcher APIs to use a new DirectoryWatcher base class.
- Introduce
FilePathExclusionsand wire upDefaultItemExcludesglobs inHotReloadDotNetWatcher. - Refactor file-watching APIs: remove
IDirectoryWatcher/FileWatcherFactory, addDirectoryWatcherwithWatchFiles/WatchContainingDirectories. - Update tests and project evaluation to cover individual-file watch and project file changes.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/.../FilePathExclusions.cs | Implement exclusion logic for DefaultItemExcludes globs and output dirs |
| src/.../FileWatcher/DirectoryWatcher.cs | New base watcher, handles per-file and directory-tree watching |
| src/.../HotReloadDotNetWatcher.cs | Integrate exclusions and project-file change re-evaluation |
| src/.../MsBuildFileSetFactory.cs | Propagate CancellationToken when loading the project graph |
| src/.../ProjectGraphNodeExtensions.cs | Expose EnableDefaultItems and DefaultItemExcludes |
| test/.../FileWatcherTests.cs | Update tests to validate per-file watch logic |
| test/.../ApplyDeltaTests.cs | Add tests for project file change scenarios |
| test/.../HotReload/CompilationHandlerTests.cs | Pass CancellationToken when loading project graph |
| test/.../HotReload/RuntimeProcessLauncherTests.cs | Rename test semaphore to ignoringChangeInExcludedFile |
| test/TestAssets/TestProjects/.../*.csproj and props files | Add or update DefineConstants and project properties for tests |
Comments suppressed due to low confidence (2)
test/dotnet-watch.Tests/FileWatcherTests.cs:25
- The fallback
[]array literal does not match the expectedImmutableHashSet<string>parameter. ReplacewatchedFileNames ?? []withwatchedFileNames ?? ImmutableHashSet<string>.Empty.
using var watcher = DirectoryWatcher.Create(dir, watchedFileNames ?? [], usePolling, includeSubdirectories: watchSubdirectories);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability to watch individual files to FileWatcher.
If enabled, uses the SDK's
DefaultItemExcludesglobs to exclude files from being watched.Otherwise, excludes
outandbindirectories as previously implemented.Implement support for project file changes (proj, props, targets).