Fix unreachable code warning for functions that return !

de-vri-es · de-vri-es · commit c8d958dfde2c · 2024-04-11T13:59:50.000+02:00
The generated code for function bodies produces an `unreachable_code`
warning if the function has a `!` return type.

The offending bit is:
```rust
if let Some(__ret) == None::&lt;!&gt; {
  // unreachable
}
```

This PR fixes the warning by simply adding `#[allow(unreachable_code)]`
to the return statement. It also adds a test for it.

This problem can only be triggered on nightly with the `never_type`
feature enabled, but it is easy to fix here.
diff --git a/src/expand.rs b/src/expand.rs
@@ -409,6 +409,7 @@ fn transform_block(context: Context, sig: &mut Signature, block: &mut Block) {
             } else {
                 quote! {
                     if let ::core::option::Option::Some(__ret) = ::core::option::Option::None::<#ret> {
+                        #[allow(unreachable_code)]
                         return __ret;
                     }
                     #(#decls)*
diff --git a/tests/test.rs b/tests/test.rs
@@ -1,6 +1,6 @@
 #![cfg_attr(
     async_trait_nightly_testing,
-    feature(impl_trait_in_assoc_type, min_specialization)
+    feature(impl_trait_in_assoc_type, min_specialization, never_type)
 )]
 #![deny(rust_2021_compatibility, unused_qualifications)]
 #![allow(
@@ -252,6 +252,25 @@ pub async fn test_unimplemented() {
     let _ = <() as Trait>::f;
 }
 
+#[cfg(async_trait_nightly_testing)]
+pub async fn test_divering_function() {
+    #[async_trait]
+    pub trait Trait {
+        async fn f() -> !;
+    }
+
+    #[async_trait]
+    impl Trait for () {
+        async fn f() -> ! {
+            loop {
+                std::thread::sleep(std::time::Duration::from_millis(1));
+            }
+        }
+    }
+
+    let _ = <() as Trait>::f;
+}
+
 // https://github.com/dtolnay/async-trait/issues/1
 pub mod issue1 {
     use async_trait::async_trait;

Original file line number	Diff line number	Diff line change
`@@ -409,6 +409,7 @@ fn transform_block(context: Context, sig: &mut Signature, block: &mut Block) {`
`409`	`409`	`} else {`
`410`	`410`	`quote! {`
`411`	`411`	`if let ::core::option::Option::Some(__ret) = ::core::option::Option::None::<#ret> {`
	`412`	`+ #[allow(unreachable_code)]`
`412`	`413`	`return __ret;`
`413`	`414`	`}`
`414`	`415`	`#(#decls)*`