Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.83
Choose a base ref
...
head repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.85
Choose a head ref
  • 17 commits
  • 10 files changed
  • 1 contributor

Commits on Sep 29, 2024

  1. Configuration menu
    Copy the full SHA
    7553de3 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Ignore needless_lifetimes clippy lint

        warning: the following explicit lifetimes could be elided: 'a
           --> src/expand.rs:443:10
            |
        443 |     impl<'a> VisitMut for AssociatedTypeImplTraits<'a> {
            |          ^^                                        ^^
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
            = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all`
            = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]`
        help: elide the lifetimes
            |
        443 -     impl<'a> VisitMut for AssociatedTypeImplTraits<'a> {
        443 +     impl VisitMut for AssociatedTypeImplTraits<'_> {
            |
    
        warning: the following explicit lifetimes could be elided: 'a
           --> tests/test.rs:453:10
            |
        453 |     impl<'a> Trait2 for &'a () {
            |          ^^              ^^
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
            = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all`
            = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]`
        help: elide the lifetimes
            |
        453 -     impl<'a> Trait2 for &'a () {
        453 +     impl Trait2 for &() {
            |
    
        warning: the following explicit lifetimes could be elided: 'a
            --> tests/test.rs:1431:10
             |
        1431 |     impl<'a> Drop for IncrementOnDrop<'a> {
             |          ^^                           ^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
        help: elide the lifetimes
             |
        1431 -     impl<'a> Drop for IncrementOnDrop<'a> {
        1431 +     impl Drop for IncrementOnDrop<'_> {
             |
    dtolnay committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    b8a555a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    eb4b038 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    c8f5733 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    03468c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Prevent upload-artifact step from causing CI failure

    This step has been failing way more than reasonable across my various repos.
    
        With the provided path, there will be 1 file uploaded
        Artifact name is valid!
        Root directory input is valid!
        Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 3000 ms...
        Attempt 2 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 6029 ms...
        Attempt 3 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 8270 ms...
        Attempt 4 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 12577 ms...
        Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact
    dtolnay committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9fc6835 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    00f9367 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2024

  1. Configuration menu
    Copy the full SHA
    7d8519d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2025

  1. Add regression test for issue 281

    Without #![feature(impl_trait_in_bindings)]:
    
        error[E0562]: `impl Trait` is not allowed in paths
            --> tests/test.rs:1680:42
             |
        1680 |         async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> {
             |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             |
             = note: `impl Trait` is only allowed in arguments and return types of functions and methods
    
        error[E0562]: `impl Trait` is not allowed in the type of variable bindings
            --> tests/test.rs:1680:42
             |
        1680 |         async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> {
             |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             |
             = note: `impl Trait` is only allowed in arguments and return types of functions and methods
             = note: see issue #63065 <rust-lang/rust#63065> for more information
             = help: add `#![feature(impl_trait_in_bindings)]` to the crate attributes to enable
             = note: this compiler was built on 2025-01-02; consider upgrading it if it is out of date
    
    With #![feature(impl_trait_in_bindings)]:
    
        error[E0562]: `impl Trait` is not allowed in paths
            --> tests/test.rs:1680:42
             |
        1680 |         async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> {
             |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
             |
             = note: `impl Trait` is only allowed in arguments and return types of functions and methods
    dtolnay committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    aff365f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85b572c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3af8236 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #282 from dtolnay/impltrait

    Support impl Trait in return type
    dtolnay authored Jan 3, 2025
    Configuration menu
    Copy the full SHA
    1cab7e4 View commit details
    Browse the repository at this point in the history
  5. Release 0.1.84

    dtolnay committed Jan 3, 2025
    Configuration menu
    Copy the full SHA
    4c8406d View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2025

  1. Add regression test for issue 283

        error[E0276]: impl has stricter requirements than trait
            --> tests/test.rs:1699:5
             |
        1692 |         async fn a();
             |         ------------- definition of `a` from trait
        ...
        1699 |     #[async_trait]
             |     ^^^^^^^^^^^^^^ impl has extra requirement `T: 'async_trait`
             |
             = note: this error originates in the attribute macro `async_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    b77d0d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9456e54 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #284 from dtolnay/selfinblock

    Omit `Self: 'async_trait` bound in impl when not needed by signature
    dtolnay authored Jan 6, 2025
    Configuration menu
    Copy the full SHA
    0c2e108 View commit details
    Browse the repository at this point in the history
  4. Release 0.1.85

    dtolnay committed Jan 6, 2025
    Configuration menu
    Copy the full SHA
    fee923d View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy