-
-
Notifications
You must be signed in to change notification settings - Fork 89
Comparing changes
Open a pull request
base repository: dtolnay/async-trait
base: 0.1.83
head repository: dtolnay/async-trait
compare: 0.1.85
- 17 commits
- 10 files changed
- 1 contributor
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7553de3 - Browse repository at this point
Copy the full SHA 7553de3View commit details
Commits on Oct 6, 2024
-
Ignore needless_lifetimes clippy lint
warning: the following explicit lifetimes could be elided: 'a --> src/expand.rs:443:10 | 443 | impl<'a> VisitMut for AssociatedTypeImplTraits<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 443 - impl<'a> VisitMut for AssociatedTypeImplTraits<'a> { 443 + impl VisitMut for AssociatedTypeImplTraits<'_> { | warning: the following explicit lifetimes could be elided: 'a --> tests/test.rs:453:10 | 453 | impl<'a> Trait2 for &'a () { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 453 - impl<'a> Trait2 for &'a () { 453 + impl Trait2 for &() { | warning: the following explicit lifetimes could be elided: 'a --> tests/test.rs:1431:10 | 1431 | impl<'a> Drop for IncrementOnDrop<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 1431 - impl<'a> Drop for IncrementOnDrop<'a> { 1431 + impl Drop for IncrementOnDrop<'_> { |
Configuration menu - View commit details
-
Copy full SHA for b8a555a - Browse repository at this point
Copy the full SHA b8a555aView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb4b038 - Browse repository at this point
Copy the full SHA eb4b038View commit details
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8f5733 - Browse repository at this point
Copy the full SHA c8f5733View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 03468c2 - Browse repository at this point
Copy the full SHA 03468c2View commit details
Commits on Nov 9, 2024
-
Prevent upload-artifact step from causing CI failure
This step has been failing way more than reasonable across my various repos. With the provided path, there will be 1 file uploaded Artifact name is valid! Root directory input is valid! Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 3000 ms... Attempt 2 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 6029 ms... Attempt 3 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 8270 ms... Attempt 4 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 12577 ms... Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact
Configuration menu - View commit details
-
Copy full SHA for 9fc6835 - Browse repository at this point
Copy the full SHA 9fc6835View commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 00f9367 - Browse repository at this point
Copy the full SHA 00f9367View commit details
Commits on Dec 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d8519d - Browse repository at this point
Copy the full SHA 7d8519dView commit details
Commits on Jan 3, 2025
-
Add regression test for issue 281
Without #![feature(impl_trait_in_bindings)]: error[E0562]: `impl Trait` is not allowed in paths --> tests/test.rs:1680:42 | 1680 | async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `impl Trait` is only allowed in arguments and return types of functions and methods error[E0562]: `impl Trait` is not allowed in the type of variable bindings --> tests/test.rs:1680:42 | 1680 | async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `impl Trait` is only allowed in arguments and return types of functions and methods = note: see issue #63065 <rust-lang/rust#63065> for more information = help: add `#![feature(impl_trait_in_bindings)]` to the crate attributes to enable = note: this compiler was built on 2025-01-02; consider upgrading it if it is out of date With #![feature(impl_trait_in_bindings)]: error[E0562]: `impl Trait` is not allowed in paths --> tests/test.rs:1680:42 | 1680 | async fn method(&self) -> Result<impl AsRef<str> + Send + Sync, Self::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `impl Trait` is only allowed in arguments and return types of functions and methods
Configuration menu - View commit details
-
Copy full SHA for aff365f - Browse repository at this point
Copy the full SHA aff365fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85b572c - Browse repository at this point
Copy the full SHA 85b572cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af8236 - Browse repository at this point
Copy the full SHA 3af8236View commit details -
Merge pull request #282 from dtolnay/impltrait
Support impl Trait in return type
Configuration menu - View commit details
-
Copy full SHA for 1cab7e4 - Browse repository at this point
Copy the full SHA 1cab7e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c8406d - Browse repository at this point
Copy the full SHA 4c8406dView commit details
Commits on Jan 6, 2025
-
Add regression test for issue 283
error[E0276]: impl has stricter requirements than trait --> tests/test.rs:1699:5 | 1692 | async fn a(); | ------------- definition of `a` from trait ... 1699 | #[async_trait] | ^^^^^^^^^^^^^^ impl has extra requirement `T: 'async_trait` | = note: this error originates in the attribute macro `async_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
Configuration menu - View commit details
-
Copy full SHA for b77d0d5 - Browse repository at this point
Copy the full SHA b77d0d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9456e54 - Browse repository at this point
Copy the full SHA 9456e54View commit details -
Merge pull request #284 from dtolnay/selfinblock
Omit `Self: 'async_trait` bound in impl when not needed by signature
Configuration menu - View commit details
-
Copy full SHA for 0c2e108 - Browse repository at this point
Copy the full SHA 0c2e108View commit details -
Configuration menu - View commit details
-
Copy full SHA for fee923d - Browse repository at this point
Copy the full SHA fee923dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.1.83...0.1.85