fix: report more detailed errors in shell.openExternal() on Windows (#33659)

trop[bot] · miniak · web-flow · commit 73e216f1825b · 2022-04-11T16:36:04.000-07:00
Co-authored-by: Milan Burda &lt;milan.burda@gmail.com&gt;
diff --git a/shell/common/platform_util_win.cc b/shell/common/platform_util_win.cc
@@ -251,7 +251,8 @@ std::string OpenExternalOnWorkerThread(
           ShellExecuteW(nullptr, L"open", escaped_url.c_str(), nullptr,
                         working_dir.empty() ? nullptr : working_dir.c_str(),
                         SW_SHOWNORMAL)) <= 32) {
-    return "Failed to open";
+    return "Failed to open: " +
+           logging::SystemErrorCodeToString(logging::GetLastSystemErrorCode());
   }
   return "";
 }

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,8 @@ std::string OpenExternalOnWorkerThread(`
`251`	`251`	`ShellExecuteW(nullptr, L"open", escaped_url.c_str(), nullptr,`
`252`	`252`	`working_dir.empty() ? nullptr : working_dir.c_str(),`
`253`	`253`	`SW_SHOWNORMAL)) <= 32) {`
`254`		`- return "Failed to open";`
	`254`	`+ return "Failed to open: " +`
	`255`	`+ logging::SystemErrorCodeToString(logging::GetLastSystemErrorCode());`
`255`	`256`	`}`
`256`	`257`	`return "";`
`257`	`258`	`}`