-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Open
Description
Preflight Checklist
- I have read the Contributing Guidelines for this project.
- I agree to follow the Code of Conduct that this project adheres to.
- I have searched the issue tracker for a feature request that matches the one I want to file, without success.
Electron Version
13.1.6
What operating system are you using?
Ubuntu
Operating System Version
Ubuntu 20.04.2 LTS
What arch are you using?
x64
Last Known Working Electron version
none
Expected Behavior
On German OS, the action that comes along with a notification is translated.
Actual Behavior
On German OS, the action that comes along with a notification is the english string "View."
Testcase Gist URL
No response
Additional Information
Thanks to the great investigative work of @Sgn-32, a Signal Desktop user, here... signalapp/Signal-Desktop#5402
...we've established that Electron is using an un-localized "View" string when creating linux notifications with an action:
electron/shell/browser/notifications/linux/libnotify_notification.cc
Lines 94 to 100 in 461db8f
// NB: On Unity and on any other DE using Notify-OSD, adding a notification | |
// action will cause the notification to display as a modal dialog box. | |
if (NotifierSupportsActions()) { | |
libnotify_loader_.notify_notification_add_action( | |
notification_, "default", "View", OnNotificationViewThunk, this, | |
nullptr); | |
} |
hiqua