Skip to content

refactor: improve Electron settings version table #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: improve Electron settings version table #1712

wants to merge 3 commits into from
+608 −488

Conversation

codebytere
Copy link
Member

Prior to this the table loaded all possible electron versions with no real ability to filter or search.

This PR virtualizes the list and adds input filtering.

Screenshot 2025-06-19 at 10 37 23 AM

@codebytere codebytere requested a review from a team as a code owner June 19, 2025 08:40
@codebytere codebytere force-pushed the settings-version-table-improvements branch 2 times, most recently from d535a3a to e926641 Compare June 19, 2025 13:18
@coveralls
Copy link

coveralls commented Jun 19, 2025 •
edited
Loading

Coverage Status

coverage: 87.905% (-0.09%) from 87.992%
when pulling 14c1ff7 on settings-version-table-improvements
into 09cf383 on main.

@codebytere codebytere force-pushed the settings-version-table-improvements branch from e926641 to 3df6e1d Compare June 24, 2025 08:01
dsanders11
dsanders11 requested changes Jul 4, 2025
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested this locally, it seems the download/delete button no longer works properly in the table. No visual update happens unless you scroll such that the button goes out of view, then scroll it back into view.

@codebytere codebytere force-pushed the settings-version-table-improvements branch from 7f6ba30 to bff81a9 Compare July 4, 2025 16:33
@codebytere
Copy link
Member Author

@dsanders11 fixed in bff81a9!

@codebytere codebytere requested a review from dsanders11 July 4, 2025 16:33
@dsanders11
Copy link
Member

@codebytere, looks like that change works well if the version is at the top of the list, but if you're scrolled down the list and click one of the buttons, I'm seeing it snap back to the top of the list, and am unable to scroll down at all until the operation (download or delete) has finished.

@codebytere codebytere force-pushed the settings-version-table-improvements branch from bff81a9 to 15b5fa2 Compare July 14, 2025 15:13
@codebytere codebytere force-pushed the settings-version-table-improvements branch from 15b5fa2 to 58f454b Compare July 14, 2025 16:34
@codebytere
Copy link
Member Author

@dsanders11 i think i've finally gotten it when you get a chance to re-review :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao Awaiting requested review from erickzhao

@ckerr ckerr Awaiting requested review from ckerr

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @coveralls @dsanders11
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy