amend 8442b5a: the separator for fig/tab labels was accidentally changed from ':' to '', and it should be '' only for theorems

yihui · yihui · commit 5ecdb043e138 · 2023-05-08T10:40:39.000-05:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: bookdown
 Type: Package
 Title: Authoring Books and Technical Documents with R Markdown
-Version: 0.33.3
+Version: 0.33.4
 Authors@R: c(
     person("Yihui", "Xie", role = c("aut", "cre"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),
     person("Christophe", "Dervieux", , "cderv@posit.co", role = c("ctb"),
diff --git a/R/ebook.R b/R/ebook.R
@@ -120,12 +120,11 @@ resolve_refs_md = function(content, ref_table, to_md = output_md()) {
     for (j in ids) {
       m = sprintf('\\(\\\\#%s\\)', j)
       if (grepl(m, content[i])) {
-        id = ''; sep = ':'
         type = gsub('^([^:]+).*$', '\\1', j)
-        if (type %in% c(theorem_abbr, 'fig', 'tab')) {
-          id = sprintf('<span id="%s"></span>', j)
-          sep = ''
-        }
+        sep = if (type %in% theorem_abbr) '' else ':'
+        id = if (type %in% c(theorem_abbr, 'fig', 'tab')) {
+          sprintf('<span id="%s"></span>', j)
+        } else ''
         label = label_prefix(type, sep = sep)(ref_table[j])
         content[i] = sub(m, paste0(id, label, ' '), content[i])
         break
