fix last credo issue and re-enable for CI

mmmries · ConnorRigby · commit 5ca92454ae0a · 2019-05-28T22:45:16.000-07:00
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -2,7 +2,7 @@ version: 2.0
 jobs:
   build:
     docker:
-      - image: circleci/elixir:1.7.3
+      - image: circleci/elixir:1.8.1
     environment:
       MIX_ENV: test
     steps:
@@ -15,8 +15,7 @@ jobs:
       - run: mix deps.get
       - run: mix deps.compile
       - run: mix compile
-      # not passing yet
-      # - run: mix credo --strict
+      - run: mix credo --strict
       - run: mix coveralls.circle
       - save_cache:
           key: v2-dependency-cache-{{ checksum "mix.lock" }}
diff --git a/lib/sqlitex/server.ex b/lib/sqlitex/server.ex
@@ -45,9 +45,9 @@ defmodule Sqlitex.Server do
 
   use GenServer
 
-  alias Sqlitex.Statement
-  alias Sqlitex.Server.StatementCache, as: Cache
   alias Sqlitex.Config
+  alias Sqlitex.Server.StatementCache, as: Cache
+  alias Sqlitex.Statement
 
   @doc """
   Starts a SQLite Server (GenServer) instance.
diff --git a/mix.exs b/mix.exs
@@ -35,7 +35,7 @@ defmodule Sqlitex.Mixfile do
     [
       {:esqlite, "~> 0.4"},
       {:decimal, "~> 1.7"},
-      {:credo, "~> 0.10", only: :dev},
+      {:credo, "~> 0.10", only: [:dev, :test]},
       {:dialyxir, "~> 1.0.0-rc.4", only: :dev, runtime: false},
       {:excoveralls, "~> 0.10", only: :test},
       {:ex_doc, "~> 0.20", only: :docs, runtime: false},

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ defmodule Sqlitex.Mixfile do`
`35`	`35`	`[`
`36`	`36`	`{:esqlite, "~> 0.4"},`
`37`	`37`	`{:decimal, "~> 1.7"},`
`38`		`- {:credo, "~> 0.10", only: :dev},`
	`38`	`+ {:credo, "~> 0.10", only: [:dev, :test]},`
`39`	`39`	`{:dialyxir, "~> 1.0.0-rc.4", only: :dev, runtime: false},`
`40`	`40`	`{:excoveralls, "~> 0.10", only: :test},`
`41`	`41`	`{:ex_doc, "~> 0.20", only: :docs, runtime: false},`